Cleanup existing std::shared_ptr usage

[kmichaelk]

No description provided.

[kmichaelk]

Regarding feasibility of shared_ptr usage, consider the following example:

auto taskData = std::make_shared<TaskData>();
{
  vector<int> in(...);
  // ...
  taskData->inputs.emplace_back(in.data());
  // ...
}
taskData->inputs[0]; // ???

[aobolensk]

Regarding feasibility of shared_ptr usage, consider the following example:

auto taskData = std::make_shared<TaskData>();
{
  vector<int> in(...);
  // ...
  taskData->inputs.emplace_back(in.data());
  // ...
}
taskData->inputs[0]; // ???

This is a poor argument against shared_ptr

[kmichaelk]

Give a counterexample. This design creates ideal conditions for dangling pointers as TaskData is not owning the memory it points too.

[kmichaelk]

That is, I don't see a situation where TaskData can be needed when the memory it points to has been freed. TaskData always goes with the container memory and doesn't own it, it's enough to copy these four pointers to ppc::core::Task directly without using shared_ptr.

[aobolensk]

Your argument about type safety is valid. As for the memory, it should not be owned, because it can be used across multiple TaskData instances. Most probably, it will need to accept shared pointer to the memory for each buffer, but this part is just not finished, AFAIU

[kmichaelk]

Right, but if it is not owned by TaskData, is there a point in storing the TaskData on heap? I believe it's enough to just copy it to the Task class instance, the key here is the lifetime of the memory it points to, not these four pointers.

[kmichaelk]

This is almost the same as allocating a shared_ptr to PerfAnalyzer - it is freed anyway after the test is completed and is not passed anywhere, why not place it on the stack?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (812626b) to head (29999a2).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   96.72%   96.72%           
=======================================
  Files          33       33           
  Lines         581      581           
  Branches      170      170           
=======================================
  Hits          562      562           
  Misses          2        2           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.