Skip to content

Commit

Permalink
Merge release v4 into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexVelezLl committed Oct 14, 2024
2 parents 777ad2f + adea2e1 commit d215525
Show file tree
Hide file tree
Showing 19 changed files with 175 additions and 135 deletions.
35 changes: 34 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -710,8 +710,41 @@ Changelog is rather internal in nature. See release notes for the public overvie

<!-- [DO NOT REMOVE-USED BY GH ACTION] PASTE CHANGELOG -->

- [#791]
- **Description:** Bump KDS version to 4.6.0.
- **Products impact:** -.
- **Addresses:** -.
- **Components:** -.
- **Breaking:** -.
- **Impacts a11y:** -.
- **Guidance:** -.

[#791]: https://github.com/learningequality/kolibri-design-system/pull/791

- [#782]
- **Description:** Update Theme Tokens to the latest specs to comply material design specifications.
- **Products impact:** Updated API.
- **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/775.
- **Components:** -.
- **Breaking:** yes.
- **Impacts a11y:** no.
- **Guidance:** Please update all `v_*` theme tokens using the mapping posted in https://github.com/learningequality/kolibri-design-system/issues/775.

[#782]: https://github.com/learningequality/kolibri-design-system/pull/782

- [#786]
- **Description:** Bump KDS version to 4.5.1.
- **Products impact:** -.
- **Addresses:** -.
- **Components:** -.
- **Breaking:** -.
- **Impacts a11y:** -.
- **Guidance:** -.

[#786]: https://github.com/learningequality/kolibri-design-system/pull/786

- [#784]
- **Description:** Adds `labelDir` prop to control rtl direction of label.
- **Description:** Add `labelDir` prop to control rtl direction of label.
- **Products impact:** new API.
- **Addresses:** https://github.com/learningequality/studio/issues/4728.
- **Components:** KCheckbox, KRadioButton.
Expand Down
2 changes: 1 addition & 1 deletion docs/common/DocsShow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
return {
display: this.block ? 'block' : 'inline-block',
padding: this.padding ? '8px 24px' : null,
backgroundColor: this.dark ? this.$themePalette.grey.v_500 : undefined,
backgroundColor: this.dark ? this.$themePalette.grey.v_700 : undefined,
};
},
},
Expand Down
14 changes: 6 additions & 8 deletions docs/pages/colors.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
<DocsColorBlock name="tokens.text" />
<DocsColorBlock name="tokens.error" />
<DocsColorBlock name="tokens.primary" />
<DocsColorBlock name="brand.primary.v_1100" />
<DocsColorBlock name="brand.secondary.v_800" />
<DocsColorBlock name="brand.primary.v_600" />
<DocsColorBlock name="brand.secondary.v_400" />
<DocsColorBlock name="palette.grey.v_400" />

<p>
Expand Down Expand Up @@ -236,16 +236,14 @@

<DocsPageSection title="Scales" anchor="#scales">
<p>
A color scale – sometimes called a color ramp – is an evenly-spaced ramp of shades for a particular color hue. In the Kolibri Design System, we follow <DocsExternalLink text="Google's Material convention" href="https://material.io/archive/guidelines/style/color.html" /> and segment colors into brightness levels, named <code>v_200</code>, <code>v_400</code>, <code>v_600</code>, <code>v_1000</code>, <code>v_1100</code>:
A color scale – sometimes called a color ramp – is an evenly-spaced ramp of shades for a particular color hue. In the Kolibri Design System, we follow <DocsExternalLink text="Google's Material convention" href="https://material.io/archive/guidelines/style/color.html" /> and segment colors into brightness levels, named <code>v_100</code>, <code>v_200</code>, <code>v_300</code>, <code>v_400</code>, <code>v_500</code>, <code>v_600</code>:
</p>
<DocsColorBlock name="palette.green.v_100" />
<DocsColorBlock name="palette.green.v_200" />
<DocsColorBlock name="palette.green.v_300" />
<DocsColorBlock name="palette.green.v_400" />
<DocsColorBlock name="palette.green.v_500" />
<DocsColorBlock name="palette.green.v_600" />
<p style="margin-left: 60px">
</p>
<DocsColorBlock name="palette.green.v_1000" />
<DocsColorBlock name="palette.green.v_1100" />
<p>
Due to the inconsistent way that humans perceive color and light, computing these scales is <DocsExternalLink text="both art and science" href="https://uxplanet.org/designing-systematic-colors-b5d2605b15c" />. It should not be done by simply sliding a "brightness" setting. We used <DocsExternalLink text="materialpalettes.com" href="https://materialpalettes.com/" /> to generate the scales for our primary and secondary brand colors. The same should be done for new themes.
</p>
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/errors/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
For operations that imply risky permanent data loss, use modals for the user to confirm they really intend to remove that data. Be sure to clearly explain the consequences.
</p>
<p>
For conditions which partially block or interrupt the user experience, use a warning icon with <code>palette.orange.v_400</code> and informative language of the consequences under the current condition.
For conditions which partially block or interrupt the user experience, use a warning icon with <code>palette.orange.v_200</code> and informative language of the consequences under the current condition.
</p>
<img src="./warning.png">
<h3>
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/klinearloader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<DocsPageSection title="Specifications" anchor="#specifications">

<ul>
<li>Progress track uses palette.grey.v_100</li>
<li>Progress track uses palette.grey.v_200</li>
<li>Progress indicator uses palette.grey.v_800</li>
<li>Progress track height is 4px</li>
<li>Include a 2px corner radius</li>
Expand Down
8 changes: 4 additions & 4 deletions docs/pages/kswitch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -33,19 +33,19 @@
<ul>
<li>
Thumb ON color:
<DocsInternalLink code text="brand.primary.v_1000" href="/colors#brand-primary-v_1000" />
<DocsInternalLink code text="brand.primary.v_500" href="/colors#brand-primary-v_500" />
</li>
<li>
Track ON color:
<DocsInternalLink code text="brand.primary.v_400" href="/colors#brand-primary-v_400" />
<DocsInternalLink code text="brand.primary.v_200" href="/colors#brand-primary-v_200" />
</li>
<li>
Thumb OFF color:
<DocsInternalLink code text="palette.grey.v_50" href="/colors#palette-grey-v_50" />
<DocsInternalLink code text="palette.grey.v_100" href="/colors#palette-grey-v_100" />
</li>
<li>
Track OFF color:
<DocsInternalLink code text="palette.grey.v_200" href="/colors#palette-grey-v_200" />
<DocsInternalLink code text="palette.grey.v_300" href="/colors#palette-grey-v_300" />
</li>
</ul>
</DocsPageSection>
Expand Down
4 changes: 2 additions & 2 deletions docs/pages/menus/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@
</li>
<li>
Option text color:
<DocsInternalLink code text="tokens.text" href="/colors#palette-grey-v_100" />
<DocsInternalLink code text="tokens.text" href="/colors#palette-grey-v_200" />
</li>
<li>
Option text hover color:
<DocsInternalLink code text="palette.grey.v_100" href="/colors#palette-grey-v_100" />
<DocsInternalLink code text="palette.grey.v_200" href="/colors#palette-grey-v_200" />
</li>
<li>
Iconography color:
Expand Down
6 changes: 3 additions & 3 deletions docs/pages/textfields/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -184,19 +184,19 @@
<li>Corner radius: 2px</li>
<li>
Fill color:
<DocsInternalLink code text="palette.grey.v_50" href="/colors#palette-grey-v_50" />
<DocsInternalLink code text="palette.grey.v_100" href="/colors#palette-grey-v_100" />
</li>
<li>
Bottom stroke color:
<DocsInternalLink code text="palette.grey.v_600" href="/colors#palette-grey-v_600" />
<DocsInternalLink code text="palette.grey.v_700" href="/colors#palette-grey-v_700" />
</li>
<li>
Bottom stroke focused color:
<DocsInternalLink code text="tokens.primary" href="/colors#tokens.primary" />
</li>
<li>
Label text color:
<DocsInternalLink code text="palette.grey.v_600" href="/colors#palette-grey-v_600" />
<DocsInternalLink code text="palette.grey.v_700" href="/colors#palette-grey-v_700" />
</li>
<li>
Focused text color:
Expand Down
4 changes: 2 additions & 2 deletions lib/KDateRange/KDateCalendar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
:style="[
(selectionOrder(weekIndex, dayInWeekIndex, 'first', activeMonthDay, activeMonthDate) === 'first') ||
(selectionOrder(weekIndex, dayInWeekIndex, 'first', activeMonthDay, activeMonthDate) === 'second') ?
{ backgroundColor: $themeBrand.primary.v_200 } : {}
{ backgroundColor: $themeBrand.primary.v_100 } : {}
]"
:class="[{
'calendar-days--disabled': isDateDisabled(weekIndex, dayInWeekIndex, activeMonthDay, activeMonthDate) || isDateDisabledLeft(weekIndex, dayInWeekIndex, activeMonthDay),
Expand Down Expand Up @@ -64,7 +64,7 @@
:style="[
(selectionOrder(weekIndex, dayInWeekIndex, 'second', nextActiveMonthDay, nextActiveMonthDate) === 'first') ||
(selectionOrder(weekIndex, dayInWeekIndex, 'second', nextActiveMonthDay, nextActiveMonthDate) === 'second') ?
{ backgroundColor: $themeBrand.primary.v_200 } : {}
{ backgroundColor: $themeBrand.primary.v_100 } : {}
]"
:class="[{
'calendar-days--disabled': isDateDisabled(weekIndex, dayInWeekIndex, nextActiveMonthDay, nextActiveMonthDate) || isDateDisabledRight(weekIndex, dayInWeekIndex, nextActiveMonthDay),
Expand Down
6 changes: 3 additions & 3 deletions lib/KDateRange/KDateDay.vue
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@
inRangeStyle() {
return this.isInRange
? {
backgroundColor: this.$themeBrand.primary.v_200,
backgroundColor: this.$themeBrand.primary.v_100,
':hover': {
backgroundColor: this.$themePalette.grey.v_200,
backgroundColor: this.$themePalette.grey.v_300,
},
}
: {};
},
selectedStyle() {
return this.isSelected
? {
backgroundColor: this.$themeBrand.primary.v_1000,
backgroundColor: this.$themeBrand.primary.v_500,
color: this.$themePalette.white + '!important',
}
: {};
Expand Down
6 changes: 5 additions & 1 deletion lib/KImg/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,11 @@
* (3) a progressive loading experience as the colored background
* is displayed while an image is loading.
*
<<<<<<< HEAD
* Its default value is `$themePalette.grey.v_50`.
=======
* Its default value is `$themePalette.grey.v_100`.
>>>>>>> release-v4
*/
backgroundColor: {
type: String,
Expand Down Expand Up @@ -175,7 +179,7 @@
baseStyles() {
const backgroundColor = this.backgroundColor
? this.backgroundColor
: this.$themePalette.grey.v_50;
: this.$themePalette.grey.v_100;
const borderRadius = this.borderRadius ? this.borderRadius : 0;
return {
Expand Down
12 changes: 6 additions & 6 deletions lib/KLogo/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@
const colorScheme = {
default: {
blobColor: defaultBrandColors.secondary.v_1000,
strokeColor: defaultBrandColors.primary.v_1000,
blobColor: defaultBrandColors.secondary.v_500,
strokeColor: defaultBrandColors.primary.v_500,
},
monoBlack: {
blobColor: materialColors.black,
Expand All @@ -146,17 +146,17 @@
blobColor: materialColors.white,
},
monoPrimary: {
blobColor: defaultBrandColors.primary.v_1000,
blobColor: defaultBrandColors.primary.v_500,
},
monoSecondary: {
blobColor: defaultBrandColors.secondary.v_1000,
blobColor: defaultBrandColors.secondary.v_500,
},
whiteGrey: {
blobColor: materialColors.grey.v_200,
blobColor: materialColors.grey.v_300,
strokeColor: materialColors.white,
},
blackGrey: {
blobColor: materialColors.grey.v_200,
blobColor: materialColors.grey.v_300,
strokeColor: materialColors.black,
},
};
Expand Down
8 changes: 4 additions & 4 deletions lib/buttons-and-links/buttonMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default {
return {
color: this.$themeTokens.primary,
':hover': {
backgroundColor: this.$themePalette.grey.v_100,
backgroundColor: this.$themePalette.grey.v_200,
},
':focus': { ...this.$coreOutline, outlineOffset: 0 },
':disabled': disabledStyle,
Expand All @@ -104,9 +104,9 @@ export default {
secondaryRaisedStyle() {
return {
color: this.$themeTokens.text,
backgroundColor: this.$themePalette.grey.v_50,
backgroundColor: this.$themePalette.grey.v_100,
':hover': {
backgroundColor: this.$themePalette.grey.v_100,
backgroundColor: this.$themePalette.grey.v_200,
},
':focus': { ...this.$coreOutline, outlineOffset: '6px' },
':disabled': disabledStyle,
Expand All @@ -119,7 +119,7 @@ export default {
return {
color: this.$themeTokens.text,
':hover': {
backgroundColor: this.$themePalette.grey.v_200,
backgroundColor: this.$themePalette.grey.v_300,
},
':focus': { ...this.$coreOutline, outlineOffset: 0 },
':disabled': disabledStyle,
Expand Down
2 changes: 1 addition & 1 deletion lib/loaders/KLinearLoader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<div
class="ui-progress-linear"
:class="classes"
:style="{ backgroundColor: $themePalette.grey.v_100 }"
:style="{ backgroundColor: $themePalette.grey.v_200 }"
>
<div
v-if="type === 'determinate'"
Expand Down
Loading

0 comments on commit d215525

Please sign in to comment.