Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In KBreadcrumbs, give any truncated (e.g. "super long it...") items a title attr so it is readable when truncated #208

Closed
jonboiser opened this issue Mar 25, 2021 · 7 comments
Assignees
Labels
category: library Shared code library Component: KBreadcrumbs good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P1 - important Priority: High impact on UX TODO: needs decisions Further discussion and planning necessary type: task Something that needs to be done

Comments

@jonboiser
Copy link
Contributor

Product

Desired behavior

Implement something similar to learningequality/kolibri#7915

But for items in KBreadcrumbs

Current behavior

In this example, the long item at the end is truncated, and there is no way to read the whole text

image

@indirectlylit indirectlylit added category: library Shared code library P1 - important Priority: High impact on UX type: task Something that needs to be done labels Nov 30, 2021
@AlexVelezLl AlexVelezLl added help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Jul 9, 2024
@RONAK-AI647
Copy link
Contributor

@MisRob @AlexVelezLl may i try this issue once , let you know the results soon.

@MisRob
Copy link
Member

MisRob commented Nov 15, 2024

Yes sure @RONAK-AI647. Is the expected behavior clear?

@RONAK-AI647
Copy link
Contributor

@MisRob I will be thankful if you summarize the expected behavior.

@MisRob
Copy link
Member

MisRob commented Nov 20, 2024

@RONAK-AI647 The issue this is trying to resolve is that when there is an item with truncated text in KBreadcrumbs, users have no way to read the whole text of that breadcrumb. The proposed solution is to use the title attribute for such an item.

However, compared to similar work in learningequality/kolibri#7915, in KBreadcrumbs, I don't see a way to detect whether an item is truncated or no since we use CSS to achieve that.

So I wonder if we could apply the title to all breadcrumb items, even those that are not truncated. @radinamatic do you have any recommendations on how to best approach this?

@MisRob MisRob added the TODO: needs decisions Further discussion and planning necessary label Nov 20, 2024
@RONAK-AI647
Copy link
Contributor

@MisRob ,take a look whenever free at the PR i raised and let me know if something else's required. If @radinamatic recommends any change or new approach , will work on that as well. Thank You.

@MisRob
Copy link
Member

MisRob commented Nov 22, 2024

Thank you @RONAK-AI647. Just responded in the PR.

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Closed by #872

@MisRob MisRob closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library Component: KBreadcrumbs good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P1 - important Priority: High impact on UX TODO: needs decisions Further discussion and planning necessary type: task Something that needs to be done
Projects
None yet
Development

No branches or pull requests

5 participants