-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding title attribute in K-Breadcrumbs #839
Adding title attribute in K-Breadcrumbs #839
Conversation
Thank you @RONAK-AI647! I will wait for @radinamatic's confirmation of the expected behavior we discussed in #208 (comment). @radinamatic you can also preview @RONAK-AI647's update here https://deploy-preview-839--kolibri-design-system.netlify.app/kbreadcrumbs/ |
@RONAK-AI647 thank you for your contribution! 👏🏽 Useful addition from the usability point of view, although since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯 🚀
Thank You @radinamatic for review .It will be great if @MisRob approves if everything is fine and push . |
Good to hear all looks well. I will finish review, @RONAK-AI647. |
Side note @radinamatic, I think screen readers may be fine, because it's just css text truncation - the whole text is present in markup |
Yes @MisRob, that was evident during the testing 👍🏽 🙂 |
It looks good to me @RONAK-AI647, thanks! Would you rebase your branch on top of the latest |
493e897
to
d9de72a
Compare
@MisRob It does not work , why these checks failing I don't understand, do i open a new pr ?? |
@MisRob I have opened a new PR because this PR after rebasing had conflicts .Take a look there and if everything is right , close them both alongwith. |
Closing in favor of #872. Thanks @radinamatic and @RONAK-AI647. |
Description
It adds title attribute in KBreadcrumbs component which enable us read the truncated texts anywhere in KBreadcrumbs.
Issue addressed
#208
Addresses #PR# HERE
Before
After screenshots
Changelog
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
Comments
Now the truncated texts which were not visible completely , can be seen easily .