Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding title attribute in K-Breadcrumbs #839

Conversation

RONAK-AI647
Copy link
Contributor

@RONAK-AI647 RONAK-AI647 commented Nov 21, 2024

Description

It adds title attribute in KBreadcrumbs component which enable us read the truncated texts anywhere in KBreadcrumbs.

Issue addressed

#208
Addresses #PR# HERE

Before

image

After screenshots

image

Changelog

  • Description: Adding title attribute in Kbreadcrumbs.
  • Products impact: updated API
  • Addresses: kolibri-design-system/issue 208
  • Components: KBreadcrumbs
  • Breaking: no
  • Impacts a11y: yes
  • Guidance: The truncated texts can be seen now.

Steps to test

  1. Add title attribute in breadcrumbs-visible-items
  2. Add title attribute in breadcrumbs-dropdown-wrapper
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Now the truncated texts which were not visible completely , can be seen easily .

@MisRob MisRob self-requested a review November 22, 2024 18:28
@MisRob MisRob self-assigned this Nov 22, 2024
@MisRob
Copy link
Member

MisRob commented Nov 22, 2024

Thank you @RONAK-AI647! I will wait for @radinamatic's confirmation of the expected behavior we discussed in #208 (comment).

@radinamatic you can also preview @RONAK-AI647's update here https://deploy-preview-839--kolibri-design-system.netlify.app/kbreadcrumbs/

@MisRob MisRob requested a review from radinamatic November 22, 2024 18:29
@radinamatic
Copy link
Member

@RONAK-AI647 thank you for your contribution! 👏🏽

Useful addition from the usability point of view, although since the title attribute is most often ignored by screen readers, this change does not have major impact on accessibility or keyboard navigation, but will support sighted users in general 🙂

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 :shipit: 🚀

@RONAK-AI647
Copy link
Contributor Author

Thank You @radinamatic for review .It will be great if @MisRob approves if everything is fine and push .

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Good to hear all looks well. I will finish review, @RONAK-AI647.

@MisRob
Copy link
Member

MisRob commented Dec 9, 2024

Side note @radinamatic, I think screen readers may be fine, because it's just css text truncation - the whole text is present in markup

@radinamatic
Copy link
Member

Yes @MisRob, that was evident during the testing 👍🏽 🙂

@MisRob
Copy link
Member

MisRob commented Dec 12, 2024

It looks good to me @RONAK-AI647, thanks! Would you rebase your branch on top of the latest develop branch and resolve conflicts so we can merge? We recently updated the Node version to v18 and vue to v2.7. So after rebasing, you'd need to switch your Node version and run yarn install. Then run yarn lint-fix.

@RONAK-AI647 RONAK-AI647 force-pushed the Adding-title-attribute-in-KBreadcrumbs branch from 493e897 to d9de72a Compare December 12, 2024 08:08
@RONAK-AI647
Copy link
Contributor Author

RONAK-AI647 commented Dec 12, 2024

@MisRob It does not work , why these checks failing I don't understand, do i open a new pr ??

@RONAK-AI647
Copy link
Contributor Author

@MisRob I have opened a new PR because this PR after rebasing had conflicts .Take a look there and if everything is right , close them both alongwith.

@MisRob MisRob mentioned this pull request Dec 13, 2024
@MisRob
Copy link
Member

MisRob commented Dec 16, 2024

Closing in favor of #872. Thanks @radinamatic and @RONAK-AI647.

@MisRob MisRob closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants