[WIP] init theming updates #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellamaki
force-pushed
the
test-themeing-updates
branch
2 times, most recently
from
c754843 to
58448b6
Compare
|
@marcellamaki This will need to be rebased and retargeted to |
marcellamaki
force-pushed
the
test-themeing-updates
branch
from
58448b6 to
ef70d4a
Compare
marcellamaki
force-pushed
the
test-themeing-updates
branch
from
ef70d4a to
6e131ca
Compare
rtibbles
force-pushed
the
test-themeing-updates
branch
2 times, most recently
from
9676679 to
c95aaad
Compare
marcellamaki
force-pushed
the
test-themeing-updates
branch
from
c95aaad to
eb34119
Compare
MisRob
reviewed
Feb 19, 2024
CHANGELOG.md
Outdated
| - **Products impact:** Brand token updates | ||
| - **Addresses:** - https://github.com/learningequality/kolibri-design-system/issues/545 | ||
| - **Components:** - | ||
| - **Breaking:** - |
There was a problem hiding this comment.
This will be a breaking update as it changes UI significantly
There was a problem hiding this comment.
I'd also appreciate if the changes could be listed here in a bit more detail, for example what categories of theming were affected. No need to explain which hex color changed into what, rather just to sum up the most important areas of impact.
There was a problem hiding this comment.
Thank you for this, I was planning to update the changelog with more info but wasn't too sure about the level of detail to include.
|
Closing this PR and will open a new one with the same changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Addresses #PR# HERE
Before/after screenshots
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
changelogReviewer guidance
Comments