Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown menu visibility when used inside KModal #493

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

KshitijThareja
Copy link
Contributor

@KshitijThareja KshitijThareja commented Nov 25, 2023

Description

This PR fixes the dropdown menu's visibility when we use KDropdownMenu in a KModal.

Issue addressed

Addresses #486

Before/after screenshots

Before:

before

After:

proof

Changelog

Steps to test

  1. Add the code given in the linked issue to the file mentioned there.
  2. Navigate to KModal documentation page to test usage of KButton and KDropdownMenu

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Thanks, @KshitijThareja, we will review.

@LianaHarris360
Copy link
Member

@KshitijThareja Thanks for working on this! The code change fixes the problem and I haven't noticed any side effects within Kolibri. Before we can approve and merge this PR, the CHANGELOG.md file will need to be updated to include the info about this change.

@KshitijThareja
Copy link
Contributor Author

@LianaHarris360 I've updated the CHANGELOG.md with the info about this particular change. I guess it can be merged now.
Thanks :)

@LianaHarris360 LianaHarris360 merged commit e27118d into learningequality:main Dec 11, 2023
8 checks passed
@MisRob
Copy link
Member

MisRob commented Dec 12, 2023

Great @KshitijThareja, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KDropdownMenu in KModal: Dropdown menu does not display in KModal
3 participants