Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom implementation of GH Action #505

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

BabyElias
Copy link
Contributor

@BabyElias BabyElias commented Dec 11, 2023

Description

  • Added custom implementation of Github Action to check whether CHANGELOG.md has been updated in the created Pull request or not
  • Removed Github 3rd party application, used official Github REST APIs for the implementation

Issue addressed

#481

Before/after screenshots

Changelog

  • #505
    • Description: Added custom implementation of GH action that checks that changelog is updated in each pull request
    • Products impact:
    • Addresses: -
    • Components: -
    • Breaking:
    • Impacts a11y:
    • Guidance: -

@MisRob
Copy link
Member

MisRob commented Dec 12, 2023

Hi @BabyElias, thank you! I asked @rtibbles to review in more detail. Also I'd like to ask if you had a chance to verify that the check still fails when the changelog file is not present in a pull request?

@BabyElias
Copy link
Contributor Author

@MisRob , Yes I did.
Attaching a screenshot of the same
image

@MisRob
Copy link
Member

MisRob commented Dec 12, 2023

@BabyElias Great, thanks! If the code looks good to Richard, I think we can merge then.

@MisRob MisRob merged commit 9476085 into learningequality:main Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants