Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused keen-ui dependency #531

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Jan 25, 2024

Description

  • Removes unused keen-ui dependency
  • I also added a small fix to changelog item link format

Changelog

  • #531
    • Description: Remove unused keen-ui dependency
    • Products impact: none
    • Addresses: -
    • Components: -
    • Breaking: -
    • Impacts a11y: -
    • Guidance: -

Steps to test

You could confirm that the dependency is indeed not used from anywhere.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

@MisRob
Copy link
Member Author

MisRob commented Jan 25, 2024

Relatedly I closed #495

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a smoke test by running the local dev server and all seemed to go alright then I smoke tested it against Kolibri release-v0.16.x branch using devserver-with-kds pointing to this local branch. No issues there.

@MisRob
Copy link
Member Author

MisRob commented Jan 30, 2024

Alright, thank you @nucleogenesis

@MisRob MisRob merged commit bfedccc into learningequality:main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants