Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 269, removed usage of tune icon #537

Closed
wants to merge 1 commit into from

Conversation

RaviKumarAgurla
Copy link

@RaviKumarAgurla RaviKumarAgurla commented Jan 29, 2024

Closes #269

@MisRob MisRob self-assigned this Jan 30, 2024
@MisRob MisRob self-requested a review January 30, 2024 12:41
@MisRob
Copy link
Member

MisRob commented Feb 2, 2024

Hello @RaviKumarAgurla, thanks for volunteering.

It seems there's misunderstanding caused by naming conflicts. Your changes remove tune/filter icon completely (to be replaced by the different settings icon) whereas the original intent of #269 was to keep the tune/filter icon but only rename it to settings. It's quite old issue so I assume it was created before we introduced yet another settings icon. So I don't think we want to remove tune completely, even though the suggested new name for it is taken now. I will also close the issue since it's obsolete. Thank you for looking into it, even though I can't merge, it helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate 'tune' alias
2 participants