Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development documentation #557

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 23, 2024

Description

This accompanies Kolibri PR learningequality/kolibri#11917 which introduces a new how to guide on using Kolibri's devserver-with-kds. Updates relevant parts of documentation to reflect that devserver-with-kds is recommended for local development with Kolibri.

Changelog

  • #557
    • Description: Updates development documentation in regards to linking products development servers to local KDS
    • Products impact: -
    • Addresses: -
    • Components: -
    • Breaking: -
    • Impacts a11y: -
    • Guidance: -

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MisRob MisRob merged commit 789b67e into learningequality:release-v3 Feb 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants