-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preserveAboveTitle prop for flexible aboveTitle slot management. #705
Add preserveAboveTitle prop for flexible aboveTitle slot management. #705
Conversation
fb3bdef
to
7ae7859
Compare
Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :) |
3a99396
to
cf67e1c
Compare
cf67e1c
to
dd2ea9b
Compare
Hi @MisRob We are good to go here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AllanOXDi, looking very well! There's just two changes I consider required. Then should be ready for merge.
Also posted one or two nice-to-have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting it ready for all slots. Very nice! Good coverage and test structure and is readable. Just one improvement it it will be perfect.
default: false, | ||
}, | ||
/** | ||
* When true, preserves the space for the footer slot even when it's empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
Also tested in the playground - works like a charm :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, thanks :)!
…ent should occupy the area designated for it or not
Description
Issue addressed
Addresses #PR# HERE
Before/after screenshots
Changelog
[#705]
KCard
updates: Add preserveAboveTitle prop for flexible aboveTitle slot management.KCard
[Add preserveAboveTitle prop for flexible aboveTitle slot management. #705] Add preserveAboveTitle prop for flexible aboveTitle slot management. #705
Steps to test
(optional) Implementation notes
At a high level, how did you implement this?
Does this introduce any tech-debt items?
Testing checklist
Reviewer guidance
After review
CHANGELOG.md
Comments