Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserveAboveTitle prop for flexible aboveTitle slot management. #705

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Jul 29, 2024

…ent should occupy the area designated for it or not

Description

Issue addressed

Addresses #PR# HERE

Before/after screenshots

Changelog

[#705]

Steps to test

  1. Step 1
  2. Step 2
  3. ...

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@MisRob MisRob self-assigned this Jul 30, 2024
@AllanOXDi AllanOXDi changed the title Add an option to configure whether the aboveTitle slot with no cont… Add preserveAboveTitle prop for flexible aboveTitle slot management. Jul 31, 2024
@AllanOXDi AllanOXDi force-pushed the thumbnail-configuration branch from fb3bdef to 7ae7859 Compare August 6, 2024 13:20
@AllanOXDi AllanOXDi marked this pull request as ready for review August 6, 2024 13:24
@MisRob
Copy link
Member

MisRob commented Aug 16, 2024

Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)

@AllanOXDi AllanOXDi force-pushed the thumbnail-configuration branch from 3a99396 to cf67e1c Compare August 16, 2024 18:38
@AllanOXDi AllanOXDi force-pushed the thumbnail-configuration branch from cf67e1c to dd2ea9b Compare August 19, 2024 12:26
@AllanOXDi
Copy link
Member Author

Hi @AllanOXDi, now the next step in our row of reviews would be to rebase on the latest develop and double-check all the changes related to slots in this PR after that. Then, please mention me, and I will review. Thanks :)

Hi @MisRob We are good to go here.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi, looking very well! There's just two changes I consider required. Then should be ready for merge.

Also posted one or two nice-to-have.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting it ready for all slots. Very nice! Good coverage and test structure and is readable. Just one improvement it it will be perfect.

lib/KCard/__tests__/KCard.spec.js Show resolved Hide resolved
lib/KCard/index.vue Outdated Show resolved Hide resolved
lib/KCard/index.vue Outdated Show resolved Hide resolved
lib/KCard/index.vue Outdated Show resolved Hide resolved
default: false,
},
/**
* When true, preserves the space for the footer slot even when it's empty.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@MisRob
Copy link
Member

MisRob commented Aug 20, 2024

Also tested in the playground - works like a charm :)

@AllanOXDi AllanOXDi requested a review from MisRob August 20, 2024 14:20
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks :)!

@AllanOXDi AllanOXDi merged commit 75629e5 into learningequality:develop Aug 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants