Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dropshadow to the latest guidelines #762

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

lokesh-sagi125
Copy link
Contributor

@lokesh-sagi125 lokesh-sagi125 commented Aug 30, 2024

Description

updating dropshadow according to the latest guidelines and replacing box-shadow eith appropriate dropshadow

updated the elemnts in the kds repo to use the dropshadows according to the latest guidelines and replace other elements like boxshadows with appropriate dropshadow.

Addresses #724

Changelog

@MisRob MisRob requested a review from akolson August 30, 2024 11:13
@MisRob MisRob added the TODO: needs review Waiting for review label Aug 30, 2024
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @lokesh-sagi125. We should be good to merge. cc @MisRob

@lokesh-sagi125
Copy link
Contributor Author

i did run yarn lint-fix before creating a pr could you tell me whats causing this?

@akolson
Copy link
Member

akolson commented Aug 30, 2024

@lokesh-sagi125 there was an KSwitch.vue had a linting issue, but thats been fixed now. Thanks!

@akolson
Copy link
Member

akolson commented Aug 30, 2024

I'll merge once the build is complete

@lokesh-sagi125
Copy link
Contributor Author

lokesh-sagi125 commented Aug 30, 2024

@akolson it was the same code , if you don't mind could you tell me why it had a linting issue , just in case i face the same issue in the future

@akolson
Copy link
Member

akolson commented Aug 30, 2024

@lokesh-sagi125 I only run the yarn lint-fix and that was enough to fix the issue! I suspect that you probably didn't run the the git add . before commiting the changes, as the linting command will tend to make changes to any unaligned files. Please confirm that this was the case.

@akolson akolson merged commit 1f3b2d3 into learningequality:develop Aug 30, 2024
8 checks passed
@lokesh-sagi125
Copy link
Contributor Author

@akolson yep, you're right i did not.

@akolson
Copy link
Member

akolson commented Aug 30, 2024

Thanks again @lokesh-sagi125 for your contribution and persistence to fix the issue! Feel free to pick up any other issue in any of our repos with the help wanted label. Looking forward to collaborating more :)

@MisRob
Copy link
Member

MisRob commented Aug 30, 2024

Thanks both and congrats @lokesh-sagi125!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants