-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dropshadow to the latest guidelines #762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @lokesh-sagi125. We should be good to merge. cc @MisRob
i did run yarn lint-fix before creating a pr could you tell me whats causing this? |
@lokesh-sagi125 there was an |
I'll merge once the build is complete |
@akolson it was the same code , if you don't mind could you tell me why it had a linting issue , just in case i face the same issue in the future |
@lokesh-sagi125 I only run the |
@akolson yep, you're right i did not. |
Thanks again @lokesh-sagi125 for your contribution and persistence to fix the issue! Feel free to pick up any other issue in any of our repos with the |
Thanks both and congrats @lokesh-sagi125! |
Description
updating dropshadow according to the latest guidelines and replacing box-shadow eith appropriate dropshadow
updated the elemnts in the kds repo to use the dropshadows according to the latest guidelines and replace other elements like boxshadows with appropriate dropshadow.
Addresses #724
Changelog