Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update changelog workflow and paste missing changelog item #765

Merged

Conversation

AlexVelezLl
Copy link
Member

Description

Fix update changelog workflow

Changelog

  • Description: Fixes update changelog workflow to avoid expecting a comment after the invisible comment <!-- [DO NOT REMOVE-USED BY GH ACTION] CHANGELOG START -->.
  • Products impact: none.
  • Addresses: -
  • Components: -
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

Tested in learningequality/test-actions#26

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@AlexVelezLl AlexVelezLl changed the title Fix update changelog workflow Fix update changelog workflow and paste missing changelog item Sep 3, 2024
@AlexVelezLl AlexVelezLl requested a review from MisRob September 3, 2024 17:20
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @AlexVelezLl! All good.

@AlexVelezLl AlexVelezLl merged commit 8835dea into learningequality:develop Sep 3, 2024
9 checks passed
@AlexVelezLl AlexVelezLl deleted the fix-update-changelog branch September 3, 2024 17:54
learning-equality-bot bot pushed a commit that referenced this pull request Sep 3, 2024
KshitijThareja pushed a commit to KshitijThareja/kolibri-design-system that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants