Bump KDS version to 5.0.0-rc4 #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-comment Backport needed changes to automate changelog updates in release-v4
KCheckbox had local data which are initialized to the given props for
`indeterminate` and `checked` and then updated in a watcher. This
resulted in that clicking a checkbox would always toggle it's
`isCurrentlyChecked` value and setting `isCurrentlyIndeterminate` to
false.
The changes here instead have KCheckbox simply use the given prop values
and does nothing to manage any internal state around whether it shows
`indeterminate` and/or `checked`.
This results in users of KCheckbox needing to be mindful of how they
manage the values they pass into KCheckbox's props as the component will
now reflect their values at all time
marcellamaki
approved these changes
Sep 3, 2024
…unopinionated KCheckbox: Remove local state management, rely on given props
Bump KDS version to 4.5.0
KshitijThareja
pushed a commit
to KshitijThareja/kolibri-design-system
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump KDS version to 5.0.0-rc4
Changelog