Remove KResponsiveElementMixin

[AlexVelezLl]

Description

Make useKResponsiveElement public and remove KResponsiveElementMixin.

Issue addressed

Addresses #711.

Changelog

• Description: Removes KResponsiveElementMixin.

• Products impact: removed API.

• Addresses: Make _useKResponsiveElement composable public and Remove KResponsiveElementMixin #711.

• Components: KResponsiveElementMixin.

• Breaking: yes.

• Impacts a11y: no.

• Guidance: Replace any use of KResponsiveElementMixin with the new composable useKResponsiveElement.

• Description: Adds new useKResponsiveElement composable.

• Products impact: new API.

• Addresses: Make _useKResponsiveElement composable public and Remove KResponsiveElementMixin #711.

• Components: -.

• Breaking: no.

• Impacts a11y: no.

• Guidance: -.

• Description: Remove use of KResponsiveElementMixin internally

• Products impact: - none

• Addresses: Make _useKResponsiveElement composable public and Remove KResponsiveElementMixin #711.

• Components: KBreadcrumbs, KFixedGrid.

• Breaking: no

• Impacts a11y: no

• Guidance: -.

Steps to test

1. Look for any reference to KResponsiveElementMixin in the lib or in the docs.
2. Do KBreadcrumbs or KFixedGrid have any regressions?

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical and brittle code paths are covered by unit tests
• The change is described in the changelog section above

Reviewer guidance

• Is the code clean and well-commented?
• Are there tests for this change?
• Are all UI components LTR and RTL compliant (if applicable)?
• Add other things to check for here

Comments

[MisRob]

Hi @AlexVelezLl, I'm getting Page Not Found when trying to access the new documentation page https://deploy-preview-783--kolibri-design-system.netlify.app/usekresponsiveelement, any idea why?

[AlexVelezLl]

Thank you for noticing the not found page @MisRob! It was beacuse I was using a wrong doc file name. I just updated this and its solved now!

[nucleogenesis]

The code changes look good to me.

One thing that came to mind is that maybe we should deprecate KResponsiveElementMixin rather than just removing it outright. This would give us time to make the requisite changes in Kolibri.

Perhaps we could keep it and put a consol.warn() in it's created() hook saying "KResponsiveElement has been deprecated and will be removed in the next release. Please use useKResponsiveElement".

In any case, once this merged can you make an issue in Kolibri for making the necessary changes there

[AlexVelezLl]

Thank you @nucleogenesis! Yes, the ideal case is deprecate it before we remove it, but we discussed this with Richard and we wanted to make the removal part of the breaking changes of KDS v5.

As per Richard's comment talking:

Yes, I think that would be good (especially as we have already explicitly deprecated the KResponsiveWindowMixin - not sure we did an explicit deprecation warning for KResponseElementMixin, but it's used significantly less - I think only once in Kolibri).

And yes, there is already an issue in Kolibri that is blocked by this PR learningequality/kolibri#12523, it is currently marked as help wanted, but I can take care of this and update the dependanbot PR updating the kds version as is a very straightforward change.

[nucleogenesis]

Everything looks good to me w/ that clarification @AlexVelezLl thank you!