Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v4.6.0 into develop and update theme tokens #800

Merged
merged 8 commits into from
Oct 21, 2024

Conversation

AlexVelezLl
Copy link
Member

Description

This PR merges v4.6.0 into develop and update theme tokens.

Changelog

  • Description: Merges v4.6.0 into develop
  • Products impact: -.
  • Addresses: -.
  • Components: -.
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @AlexVelezLl! The merge up commits look right, and I've done a spot check for the colors on the places where the theme tokens also had to be updated on the docs pages. The build works, and I didn't encounter any errors and all of the colors displayed as expected.

@AlexVelezLl
Copy link
Member Author

Thank you @marcellamaki!

@AlexVelezLl AlexVelezLl merged commit 0602f0d into learningequality:develop Oct 21, 2024
8 checks passed
@AlexVelezLl AlexVelezLl deleted the merge-v4.6.0 branch October 21, 2024 12:33
learning-equality-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants