-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed case-sensitive sorting for KTable #854
Conversation
Thank you for keeping taking care of the table, @BabyElias :) I will invite my colleague @AllanOXDi for review. One suggestion from me would be to add a unit test to cover this, if you'd like to do so meanwhile. |
@AllanOXDi for reference, this issue #852 was open by @BabyElias after we agreed together it's expected behavior. |
I have updated the test cases to cover strings having both lower and uppercase characters. |
* @param {Number} index - The index of the column to sort by. | ||
* @returns {any} - The value to be used for sorting. | ||
*/ | ||
const getSortValue = (row, index) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat
This looks good to me too. @AllanOXDi feel free to merge after you've seen the latest changes if you think all is ready :) Thanks both! |
I made a small tweak to the changelog "Description" to be a bit more specific. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Thanks @BabyElias
Description
This PR fixes the issue caused by case-sensitive sorting for KTable where uppercase characters were sorted before lowercase characters.
toLocaleLowerCase()
method has been used to ensure internationalisation concerns are addressed while standardising strings to lower case for comparison.Issue addressed
Addresses #852
Before/after screenshots
Before -
After -
Changelog
Does this introduce any tech-debt items?
No
Testing checklist
Reviewer guidance
Comments