Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Margins to Empty Table Message for Consistent Spacing #884

Closed
wants to merge 0 commits into from

Conversation

karankoder
Copy link
Contributor

@karankoder karankoder commented Jan 10, 2025

Description

This PR resolves the issue of inconsistent margins when an empty table message is displayed. Previously, the empty message lacked the margin-top and margin-bottom spacing that is present when the table contains data, resulting in a visual inconsistency.

Issue addressed

Closes #881

Addresses #881

Before/after screenshots

Before Image
After Image

Changelog

  • Description: Added margin-top: 16px and margin-bottom: 16px to the empty table message to ensure consistent spacing with the table header and data rows.
  • Products impact: bugfix
  • Addresses: - [KTable]: Add margin to empty text #881
  • Components: KTable
  • Breaking: no
  • Impacts a11y: no
  • Guidance:

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KTable]: Add margin to empty text
1 participant