Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TextTruncator component #11287

Closed
2 tasks
MisRob opened this issue Sep 22, 2023 · 9 comments · Fixed by #11288
Closed
2 tasks

Remove TextTruncator component #11287

MisRob opened this issue Sep 22, 2023 · 9 comments · Fixed by #11288
Assignees
Labels
good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome

Comments

@MisRob
Copy link
Member

MisRob commented Sep 22, 2023

Summary

We recently stopped using TextTruncator component completely in favor of using TextTruncatorCss. Let's remove TextTruncator from the codebase.

Acceptance Criteria

  • TextTruncator exists no more
  • Please double-check that TextTruncator is really not used anywhere
@MisRob MisRob added help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 22, 2023
@MisRob
Copy link
Member Author

MisRob commented Sep 22, 2023

This is already reserved for contribution for yash1378

@MisRob
Copy link
Member Author

MisRob commented Sep 22, 2023

Note that you need to target release-v0.16.x branch since that's the branch where we recently stopped using TextTruncator everywhere

@V0YD23
Copy link
Contributor

V0YD23 commented Sep 22, 2023

hi @MisRob please assign me this issue and where can i connect with you for the guidance

@MisRob
Copy link
Member Author

MisRob commented Sep 22, 2023

Great, you're assigned @yash1378. For questions about this particular issue, you can use this comments section. Please study CONTRIBUTING.md for guidance on development server where you will also find out where to report dev server problems if you experience any. Note there may be other team members jumping in and generally it might take us few days to reply.

@V0YD23
Copy link
Contributor

V0YD23 commented Sep 22, 2023

Great, you're assigned @yash1378. For questions about this particular issue, you can use this comments section. Please study CONTRIBUTING.md for guidance on development server where you will also find out where to report dev server problems if you experience any. Note there may be other team members jumping in and generally it might take us few days to reply.

done mam i guess i have resolved this issue and also made pr and thank you very much mam for helping me out i t was getting messed up in head as how to contribute and where to thanx once again for helping me out and no issues for the time , i just want to become a part of open source community

@MisRob
Copy link
Member Author

MisRob commented Sep 23, 2023

Great @yash1378, welcome to the open-source community!

@V0YD23
Copy link
Contributor

V0YD23 commented Sep 23, 2023

Great @yash1378, welcome to the open-source community!

thank you mam is there any other issue in your known on which i can work i have worked with js,reactjs,nodejs,nextjs and also with sockets and mongo

@MisRob
Copy link
Member Author

MisRob commented Sep 25, 2023

Hi @yash1378, I will soon be opening some more issues for Kolibri, so you can check on "good first issue"s again from time to time. We also have other products where we welcome contributions. One of my colleagues recommends this one learningequality/studio#4272. We'll add a bit more information on where to find the place to fix soon. If you'd be interested, please send us a message there and meanwhile you can try to setup Studio development server.

@V0YD23
Copy link
Contributor

V0YD23 commented Sep 25, 2023

Hi @yash1378, I will soon be opening some more issues for Kolibri, so you can check on "good first issue"s again from time to time. We also have other products where we welcome contributions. One of my colleagues recommends this one learningequality/studio#4272. We'll add a bit more information on where to find the place to fix soon. If you'd be interested, please send us a message there and meanwhile you can try to setup Studio development server.

Sure Mam , I will keep checking the good first issues time to time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants