Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextTruncator.vue is totally removed from the entire codebase #11288

Merged

Conversation

V0YD23
Copy link
Contributor

@V0YD23 V0YD23 commented Sep 22, 2023

Summary

References

Closes #11287

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob
Copy link
Member

MisRob commented Sep 22, 2023

Hi @yash1378, thanks! Could you please follow PR guidelines and fill in the sections at least briefly? So that any team member can review and understand. Thank you.

@V0YD23
Copy link
Contributor Author

V0YD23 commented Sep 22, 2023

Hi @yash1378, thanks! Could you please follow PR guidelines and fill in the sections at least briefly? So that any team member can review and understand. Thank you.

ok mam i will take care of that

@MisRob MisRob requested review from LianaHarris360 and pcenov and removed request for pcenov September 23, 2023 13:14
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 23, 2023
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Besides one small correction, I can confirm that the TextTruncator component has been removed from the codebase.

kolibri/core/assets/src/core-app/apiSpec.js Outdated Show resolved Hide resolved
@LianaHarris360 LianaHarris360 added TODO: needs updates Needs changes based on review and removed TODO: needs review Waiting for review labels Sep 25, 2023
@V0YD23
Copy link
Contributor Author

V0YD23 commented Sep 25, 2023

Thanks for working on this! Besides one small correction, I can confirm that the TextTruncator component has been removed from the codebase.

done the changes as required

@LianaHarris360 LianaHarris360 merged commit 8c711ec into learningequality:release-v0.16.x Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIZE: medium TODO: needs updates Needs changes based on review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TextTruncator component
3 participants