Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library - Connection state's position when there are no libraries around #11442

Open
pcenov opened this issue Oct 20, 2023 · 21 comments
Open

Library - Connection state's position when there are no libraries around #11442

pcenov opened this issue Oct 20, 2023 · 21 comments
Assignees
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@pcenov
Copy link
Member

pcenov commented Oct 20, 2023

Observed behavior

The connection state text 'No other libraries around you right now' should be positioned under the 'Other libraries' label as specified in Figma.

Steps to reproduce the issue

  1. Install the latest build from Fix up reactivity and display issues for remote libraries on LibraryPage and ExploreLibrariesPage #11419 and setup a full facility.
  2. Go to the Library page without having an active internet connection.
  3. Observe the position of the 'No other libraries around you right now' text

More information

2023-10-20_16-02-24

Usage Details

Kolibri 0.16beta6
Ubuntu - Chrome, Firefox

@pcenov
Copy link
Member Author

pcenov commented Oct 20, 2023

@radinamatic

@marcellamaki marcellamaki added P2 - normal Priority: Nice to have APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Oct 23, 2023
@marcellamaki marcellamaki added the help wanted Open source contributors welcome label Feb 13, 2024
@imyuanhui
Copy link

hi @marcellamaki , i'd like to work on this issue!

@AlexVelezLl
Copy link
Member

Hi! @imyuanhui. Thanks for your interest in contributing to Kolibri! I will assign this issue to you. Let us know if you have any questions 👐.

@marcellamaki
Copy link
Member

Hi @imyuanhui - are you interested in working on this issue still? If you are not planning to, that's not problem, but please let us know as we will re-assign it. Thank you!

@MisRob MisRob added the good first issue Self-contained, straightforward, low-complexity label Jun 11, 2024
@MisRob
Copy link
Member

MisRob commented Jun 11, 2024

Screenshot from Figma of the expected UI
Screenshot from 2024-06-11 10-08-10

@JennyPoudel
Copy link

Hi. I am interested to work on this issue. Can you please assign?

@rtibbles
Copy link
Member

Yes, absolutely!

@MohamedAazil
Copy link

Hi @MisRob I'm interested in working on this issue. Can you assign it to me?

@AllanOXDi
Copy link
Member

Hi @MohamedAazil , I will assign this issue to you. Thanks for your interest in contributing to Kolibri

@MohamedAazil
Copy link

Thank you @AllanOXDi i will get back to you when I'm done

@manzil-infinity180
Copy link
Contributor

@MohamedAazil any updates?
if not can i take this issue

@AlexVelezLl
Copy link
Member

Hey @manzil-infinity180. Thanks for your interest in contributing to Kolibri! Let's give Mohamed time to solve the issue. In the meantime you’re welcome to find a "help wanted" issue with no assignee :)

@yashhash2
Copy link

@AlexVelezLl can I take this issue?

@MohamedAazil
Copy link

Ok you may take this issue
I've been trying to figure things out for so long yet it doesn't seem like the issue is on my level

@AllanOXDi AllanOXDi assigned yashhash2 and unassigned MohamedAazil Dec 4, 2024
@AllanOXDi
Copy link
Member

Okay @yashhash2 I have assigned it to you

@MisRob
Copy link
Member

MisRob commented Dec 4, 2024

Hi @yashhash2, note this previous attempt that includes @LianaHarris360's review, it's a good guidance #12405

@yashhash2
Copy link

#12948 (comment) created a PR please review it :)

@MisRob
Copy link
Member

MisRob commented Dec 16, 2024

Thanks @yashhash2, I posted some first feedback earlier today

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

Hi @yashhash2, I wanted to mention that Learning Equality will be closed from December 23 to January 5.

@yashhash2
Copy link

ooh is there anyother way to stay in contact with this organization @MisRob in case of doubts.

@MisRob
Copy link
Member

MisRob commented Dec 17, 2024

ooh is there anyother way to stay in contact with this organization @MisRob in case of doubts.

No @yashhash2, this is well-deserved time for the whole team to rest fully :) We'll be happy to get back to you later in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests