Library - Connection state's position when there are no libraries around fixed #12405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Learn
|
SS of the UI: |
|
Thanks for your first contribution, @JennyPoudel! We will review. |
Build Artifacts
|
LianaHarris360
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Hi @JennyPoudel, great work on this! I noticed on smaller screens, the position of the string drops beneath the title of the first library, but it should remain positioned beneath “Other Libraries”.
Another issue occurring on smaller screens is the string being positioned a little too far left, like shown in the screenshot below with the string No other libraries around you right now.
|
@LianaHarris360 thankyou for the review, I will look into that |
marcellamaki
modified the milestones:
Kolibri 0.17: Planned Patch 1,
Kolibri 0.17: Planned Patch 2
|
Hi @JennyPoudel, are you planning to finish this or is there something we can help with? |
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##11442