Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponsiveElementMixin by useKResponsiveElement composable #12523

Closed
4 tasks
AlexVelezLl opened this issue Aug 1, 2024 · 1 comment
Closed
4 tasks
Labels
help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@AlexVelezLl
Copy link
Member

This issue is blocked by learningequality/kolibri-design-system#711.

Summary

This issue involves replacing all occurrences of KResponsiveElementMixin with the new useKResponsiveElement composable throughout the Kolibri codebase.

This includes updating imports for properties like elementWidth and elementHeight, and ensuring all affected components are manually tested to confirm they work correctly with the new composable.

Acceptance criteria

  • useKResponsiveElement composable is used instead of KResponsiveElementMixin in all Kolibri codebase.
  • All occurences of properties provided by KResponsiveElementMixin (elementWidth, elementHeight) are imported from useKResponsiveElement composable in the component where KResponsiveElementMixin mixin is being removed.
  • All components where KResponsiveElementMixin is replaced are manually tested and still work as expected with useKResponsiveElement composable.
  • There is a list of affected pages the a pull request description (e.g. their URLs).
@MisRob MisRob added P2 - normal Priority: Nice to have help wanted Open source contributors welcome labels Aug 2, 2024
@AlexVelezLl
Copy link
Member Author

Closed by #12717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

2 participants