-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource selection UX- Improvement #11815
Resource selection UX- Improvement #11815
Conversation
Build Artifacts
|
0ae71ae
to
fd0b6d5
Compare
fd0b6d5
to
f9e1236
Compare
f9e1236
to
5d1b9c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the loadingMore
needs to be put onto the first v-if
at the top like v-if="loading && !loadingMore"
as I'm still seeing the page flash when I click to "view more".
Otherwise, changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Allan - this is good to merge.
Summary
Replaced the
View more
button with a KCircularLoader when clicked and things are loading.Added
loading ref
in the useQuizResourcesThe View more
button fetches the same amount of resources that the initial fetchThe
back arrow
is now only visible when there is somewhere within the panel to go back to.The
back arrow
also serves as clicking the browser "Back" buttoncloses #11733
References
#11733
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)