Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource selection UX- Improvement #11815

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Jan 29, 2024

Summary

Replaced the View more button with a KCircularLoader when clicked and things are loading.

Added loading ref in the useQuizResources

The View more button fetches the same amount of resources that the initial fetch

The back arrow is now only visible when there is somewhere within the panel to go back to.
The back arrow also serves as clicking the browser "Back" button
closes #11733

References

#11733

Reviewer guidance

  • Confirm that the "View more" button is effectively replaced with a KCircularLoader when clicked and during the loading state
  • Review the implementation of a separate "loading" ref, loadingMore, to manage the loading state for the "View more"
  • Confirm that the back arrow icon is only visible when there is a valid context within the panel to go back to.
  • Clarify that the back arrow does not close the panel; rather, it navigates back within the panel

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jan 29, 2024
@AllanOXDi AllanOXDi force-pushed the resouce-selection_ux_improvement branch from 0ae71ae to fd0b6d5 Compare January 30, 2024 17:13
@AllanOXDi AllanOXDi requested review from ozer550 and nucleogenesis and removed request for ozer550 February 2, 2024 17:47
@AllanOXDi AllanOXDi force-pushed the resouce-selection_ux_improvement branch from fd0b6d5 to f9e1236 Compare February 9, 2024 21:03
@AllanOXDi AllanOXDi force-pushed the resouce-selection_ux_improvement branch from f9e1236 to 5d1b9c9 Compare February 9, 2024 21:36
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the loadingMore needs to be put onto the first v-if at the top like v-if="loading && !loadingMore" as I'm still seeing the page flash when I click to "view more".

Otherwise, changes look good

@AllanOXDi AllanOXDi marked this pull request as ready for review February 9, 2024 22:43
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allan - this is good to merge.

@nucleogenesis nucleogenesis merged commit 18a9f32 into learningequality:develop Feb 12, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz Creation Select Resources - UX Improvements
2 participants