-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form to add address after device import #12136
Merged
jredrejo
merged 1 commit into
learningequality:release-v0.16.x
from
jredrejo:add_new_device_post
May 9, 2024
Merged
Add form to add address after device import #12136
jredrejo
merged 1 commit into
learningequality:release-v0.16.x
from
jredrejo:add_new_device_post
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jredrejo
added
TODO: needs review
Waiting for review
bug
Behavior is wrong or broken
labels
May 7, 2024
github-actions
bot
added
APP: Device
Re: Device App (content import/export, facility-syncing, user permissions, etc.)
DEV: frontend
SIZE: small
labels
May 7, 2024
Build Artifacts
|
marcellamaki
reviewed
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jredrejo - works perfectly fine now! |
pcenov
approved these changes
May 9, 2024
radinamatic
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APP: Device
Re: Device App (content import/export, facility-syncing, user permissions, etc.)
bug
Behavior is wrong or broken
DEV: frontend
SIZE: small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a device to import content after the setup finishes was not implemented
References
Closes: #12085
Reviewer guidance
Following the steps described by @pcenov in the referenced issue you must be able to add a new device to import content after the setup wizard finishes
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)