Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form to add address after device import #12136

Merged

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented May 7, 2024

Summary

Adding a device to import content after the setup finishes was not implemented

References

Closes: #12085

Reviewer guidance

Following the steps described by @pcenov in the referenced issue you must be able to add a new device to import content after the setup wizard finishes

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added TODO: needs review Waiting for review bug Behavior is wrong or broken labels May 7, 2024
@jredrejo jredrejo added this to the Kolibri 0.16: Planned Patch 2 milestone May 7, 2024
@jredrejo jredrejo requested a review from marcellamaki May 7, 2024 17:19
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: small labels May 7, 2024
@marcellamaki marcellamaki self-assigned this May 7, 2024
@marcellamaki marcellamaki requested a review from radinamatic May 7, 2024 17:30
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code review, this seems like the correct change. I'll defer to the QA team for manual review to confirm it's solving the problem that @pcenov encountered! Thank you @jredrejo

@pcenov
Copy link
Member

pcenov commented May 9, 2024

Thanks @jredrejo - works perfectly fine now!

@pcenov pcenov self-requested a review May 9, 2024 08:07
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 :shipit:

@radinamatic radinamatic removed the TODO: needs review Waiting for review label May 9, 2024
@jredrejo jredrejo merged commit 7ca7454 into learningequality:release-v0.16.x May 9, 2024
34 checks passed
@jredrejo jredrejo deleted the add_new_device_post branch May 9, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) bug Behavior is wrong or broken DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants