Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EQM: Section re-ordering moved to side panel, remove from section editor #12432

Merged
merged 6 commits into from
Jul 12, 2024
Merged

EQM: Section re-ordering moved to side panel, remove from section editor #12432

merged 6 commits into from
Jul 12, 2024

Conversation

nucleogenesis
Copy link
Member

Summary

Putting this draft up for feedback - will aim to fix issues around SectionEditor in this PR tomorrow.

2024-07-09.16-30-27.mp4

References

…

Reviewer guidance

…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0b1.dev0+git.36.gd8f31c16-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0b1.dev0+git.36.gd8f31c16-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0b1.dev0+git.36.gd8f31c16.dmg
Android Package (APK) kolibri-0.17.0b1.dev0+git.36.gd8f31c16-0.1.3-debug.apk
TAR file kolibri-0.17.0b1.dev0+git.36.gd8f31c16.tar.gz
WHL file kolibri-0.17.0b1.dev0+git.36.gd8f31c16-py2.py3-none-any.whl

@radinamatic
Copy link
Member

Recapping what we already mentioned during the sync-up:

  • Make sure we have an H1 in the sidebar
    • if not time consuming, put that H1 in the topbar
    • suggestion to concatenate the existing strings Edit + - + Section order
  • Align the Apply settings button right
  • Make sure there is only one Current section
1 2
2024-07-10_18-58-16 2024-07-10_19-14-51

@nucleogenesis nucleogenesis marked this pull request as ready for review July 11, 2024 16:17
@radinamatic
Copy link
Member

  • ✔️ for the H1
  • No problem to keep the Section order within the panel and not in the topbar, but could we at least insert the Edit string in front, as I suggested above?
  • I again managed to replicate the 3 current sections: it happens when the order panel is opened, and page reloaded at that point; when loading finishes, all 3 sections are marked as current. This persists even after the quiz is saved and closed 😳
1 2
2024-07-11_19-41-13 2024-07-11_19-42-13

@rtibbles rtibbles changed the base branch from develop to release-v0.17.x July 12, 2024 16:14
marcellamaki
marcellamaki approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested out the problems that Radina ran into, and can't reproduce them. Code changes look okay (I did add one small non-blocking comment)

marcellamaki
marcellamaki reviewed Jul 12, 2024
View reviewed changes
kolibri/plugins/coach/assets/src/composables/quizCreationSpecs.js Outdated
@@ -117,7 +117,7 @@ export const QuizQuestion = {
export const QuizSection = {
section_id: {
type: String,
default: () => String(performance.now()),
default: () => Math.random().toString(36).substring(7),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking, this is not super easy to read

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I added a comment. It's a snippet I've used before to get a random-enough string. Do you think that helps?

@nucleogenesis nucleogenesis merged commit 791cafc into learningequality:release-v0.17.x Jul 12, 2024
33 checks passed
This was referenced Jul 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

@pcenov pcenov Awaiting requested review from pcenov

Assignees
No one assigned
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nucleogenesis @radinamatic @marcellamaki