Limit max questions per section to 25.

[rtibbles]

Summary

• Limits max questions per section to 25
• Hides add more questions button in section editor when section already has the max number of questions

Reviewer guidance

Does this make the learner and coach experience better?

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.17.0b3.dev0+git.38.g7fddce29-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0b3.dev0+git.38.g7fddce29-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0b3.dev0+git.38.g7fddce29.dmg
Android Package (APK)	kolibri-0.17.0b3.dev0+git.38.g7fddce29-0.1.3-debug.apk
TAR file	kolibri-0.17.0b3.dev0+git.38.g7fddce29.tar.gz
WHL file	kolibri-0.17.0b3.dev0+git.38.g7fddce29-py2.py3-none-any.whl

[radinamatic]

I like the fact that the limit is fixed in the input field, I'm just missing explicit message to the user.

Especially if they already added 20 questions and they click the button Add more questions in the Settings sidebar. We should at least conditionally remove that button if the section already has 20 questions, and optionally (if possible and not too hacky) already include the option to add another section (not sure if that is doable from the settings sidebar of another section).

There is already a max question string, you would only need to set the variable to be fixed to 20.

[rtibbles]

Ah yes, well, that would need to be fixed regardless of the limit, if it's not disabling for 20, it won't be disabling for 50.

[radinamatic]

Great, the button is now not active when more than 25 questions are specified in the input field! 👍🏽

[radinamatic]

LGTM! 💯

[marcellamaki]

code review looks fine, and going through the UI, agree with Radina that this looks good. And I think it's a preferable workflow