-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle frontend loaded zip archive content (h5p, bloomd) that contains large files #12805
base: develop
Are you sure you want to change the base?
Conversation
…t for most cases.
Build Artifacts
|
Hi @rtibbles, I noticed the following issues:
large.mp4
And 'Unidad 1 - Herramientas para el empoderamiento' from the QA channel, where the player buttons are missing: I've created the following test channel |
Thanks @pcenov - I guess there was a good reason I marked this as a draft! |
Note the backend parts of this PR have been cherry-picked into this PR: #12993 |
Summary
References
Fixes #9761
Reviewer guidance
Does this work for H5P files that contain large media assets like videos and audio?
Questions - this covers the previously encountered case where H5P files contained incredibly large individual files, but doesn't cover the case where the archive files themselves are just enormous, but contain lots of tiny files. Have we encountered any archives where this may be the issue? Is there any benefit to limiting the size of segments and lazily loading them on demand? These may be empirical questions best answered by looking at lots of H5P files.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)