Moved login/logout logic into the useUser composable and updated references #12915
Conversation
…osition API useUser
Build Artifacts
|
|
|
||
| describe('HeartBeat', function () { | ||
| stubWindowLocation(beforeAll, afterAll); | ||
| // replace the real XHR object with the mock XHR object before each test | ||
| beforeEach(() => mock.setup()); | ||
| beforeEach(() => useUser.mockImplementation(() => useUserMock())); |
There was a problem hiding this comment.
Is there a particular reason for mock.setup() not to be called anymore? I'm wondering if this is related to the failing tests
There was a problem hiding this comment.
Sorry for the oversight. I’ve fixed this now.
There was a problem hiding this comment.
In the description you mentioned that the logic was moved from an actions.js file but there are no changes to any Vuex files included.
I also see that heartbeat.js may need to be updated to use the useUser module as it is still calling dispatch('setSession', ...) here.
I had a comment in the heartbeat.spec.js file re: the tests but I think that updating heartbeat.js might be the key
@nucleogenesis Thanks for pointing that out. I had initially planned on removing the Vuex logic after successfully migrating the login and session logic to the new Composition API. However, I got stuck with the heartbeat.spec.js tests. I’ve now removed the login/logout and session logic from the Vuex files.
Regarding the heartbeat.js, I refactored the store.dispatch to use the setSession method, but the failing tests persist. I suspect the issue might be related to xhr-mock, but I’m unable to pinpoint the exact cause. Please let me know if you have any suggestions. |
There was a problem hiding this comment.
I added one comment to the mock function for setSession and after some thinking and looking at the code locally I'm not sure precisely what the fix is, but I'm feeling it is very likely to do with that function altogether and it's differences to the real setSession.
Another thing I saw was that the kolibriLogin action is being dispatched a few places - such as the store.spec.js file
Thank you for your effort on this. I hope anything I've said can be helpful. I'll keep thinking about this and come back to it again tomorrow if I can
| session, // Make session mutable for test scenarios | ||
|
|
||
| // Actions | ||
| setSession: jest.fn(({ session: newSession, clientNow }) => { |
There was a problem hiding this comment.
One of the failing tests re: not calling serverTime w/ clientNow may be fixed by calling it here.
Summary
Login/logout and session logic is moved into
useUsercomposable fromaction.js. Refactored vuex state into module level state. References toCORE_SET_SESSIONis updated to use the setSession method from useUser composable.References
fixes #12204
Reviewer guidance
after updating references to
CORE_SET_SESSIONinheartbeat.spec.jsfile, some tests still failed. I am unable to figure out why these tests are failing. I updated the mock file and implementated it as written in documentation.