Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the channel labels from the non-public ContentNode API #12985

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Remove the channel labels from the non-public ContentNode API #12985

merged 4 commits into from
Jan 8, 2025

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Jan 8, 2025

Summary

  • Add logic to remove channels metadata for non public contentNode API.
  • Restructure caching.
  • Add tests.

References

closes #12842

Reviewer guidance

Run pytest!

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a0.dev0_git.307.g59549813.pex
Windows Installer (EXE) kolibri-0.18.0a0.dev0+git.307.g59549813-windows-setup-unsigned.exe
Mac Installer (DMG) kolibri-0.18.0a0.dev0+git.307.g59549813.dmg
Android Package (APK) kolibri-0.18.0a0.dev0+git.307.g59549813-0.1.4-debug.apk
TAR file kolibri-0.18.0a0.dev0+git.307.g59549813.tar.gz
WHL file kolibri-0.18.0a0.dev0+git.307.g59549813-py2.py3-none-any.whl

rtibbles
rtibbles approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@rtibbles
Copy link
Member

rtibbles commented Jan 8, 2025

Build errors are fixed on develop, merging.

@rtibbles rtibbles merged commit cb7b118 into learningequality:develop Jan 8, 2025
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the channel labels from the non-public ContentNode API
2 participants
@ozer550 @rtibbles