adds pr review comments

learningequality · Sep 7, 2022 · b9f89e9 · b9f89e9
1 parent c491ac0
commit b9f89e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUploadItem.vue b/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUploadItem.vue
@@ -136,7 +136,7 @@
       },
       formattedFileDisplay() {
         const fileName = this.fileDisplay.original_filename;
-        if (fileName === 'file' || (fileName && !fileName.length)) {
+        if (fileName === 'file' || !fileName) {
           return this.$tr('unknownFile');
         }
         return fileName;

diff --git a/...uration/contentcuration/frontend/channelEdit/views/files/__tests__/fileUploadItem.spec.js b/...uration/contentcuration/frontend/channelEdit/views/files/__tests__/fileUploadItem.spec.js
@@ -31,12 +31,18 @@ describe('fileUploadItem', () => {
   describe('render', () => {
     it("'Unknown filename' should be displayed if original_filename is 'file'", () => {
       let file = {
-        id: 'file-1',
         original_filename: 'file',
       };
       let wrapper = makeWrapper({}, file);
       expect(wrapper.find('[data-test="file-link"]').text()).toBe('Unknown filename');
     });
+    it("'Unknown filename' should be displayed if original_filename is ''", () => {
+      let file = {
+        original_filename: '',
+      };
+      let wrapper = makeWrapper({}, file);
+      expect(wrapper.find('[data-test="file-link"]').text()).toBe('Unknown filename');
+    });
     it("original_filename should be displayed if its value is not 'file'", () => {
       let file = {
         id: 'file-1',