Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misalignment of copy failure retry CTA #4272

Closed
bjester opened this issue Sep 5, 2023 · 12 comments
Closed

Misalignment of copy failure retry CTA #4272

bjester opened this issue Sep 5, 2023 · 12 comments
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome

Comments

@bjester
Copy link
Member

bjester commented Sep 5, 2023

We recently pushed a feature that allows users to retry failed copy of contentnodes. There's an UI bug between the alignment of copying message and retry action message as shown in the below image --

screenshot_2023-07-17_at_1 35 40_pm_720

Here are some pointers to get started --

  • To reproduce the copy error UI state in the frontend you will need to raise an exception from the backend copying function. The exception from the backend copying function can be raised by raising any ValidationError.

  • The copying message text is present in ContentNodeListItem.

  • The retry copy action text is present in ContentNodeEditListItem.

@vkWeb vkWeb added good first issue Self-contained, straightforward, low-complexity DEV: frontend help wanted Open source contributors welcome labels Sep 6, 2023
@marcellamaki marcellamaki self-assigned this Sep 11, 2023
@V0YD23
Copy link

V0YD23 commented Sep 25, 2023

hi @MisRob mam , I am here

@MisRob
Copy link
Member

MisRob commented Sep 25, 2023

Thanks, @yash1378. @vkWeb will provide you with a bit more info on where to find this place. See https://github.com/learningequality/studio#readme for how to setup Studio.

@vkWeb
Copy link
Member

vkWeb commented Sep 25, 2023

@yash1378 Hi Yash, first, as already said by @MisRob, setup Studio and then try reproducing the copy error UI state as mentioned in the updated post above.

Yash, once you have setup Studio and reproduced copy error UI state, try using chrome dev tools to see the CSS properties of the copying error message. Please let me know if you have any questions. Feel free to ask even the silliest of questions, every question is important.

We appreciate your help Yash. Looking forward!

@V0YD23
Copy link

V0YD23 commented Sep 25, 2023

@yash1378 Hi Yash, first, as already said by @MisRob, setup Studio and then try reproducing the copy error UI state as mentioned in the updated post above.

Yash, once you have setup Studio and reproduced copy error UI state, try using chrome dev tools to see the CSS properties of the copying error message. Please let me know if you have any questions. Feel free to ask even the silliest of questions, every question is important.

We appreciate your help Yash. Looking forward!

thanx sir for helping , yes i will try hard

@vkWeb
Copy link
Member

vkWeb commented Oct 5, 2023

@yash1378 what's up, how's all going?

@vkWeb
Copy link
Member

vkWeb commented Oct 13, 2023

@yash1378 I'm unassigning this as it looks like you are away. Anyways, thanks for looking into this, appreciated!

This issue is now open to take on for others.

@marcellamaki marcellamaki added this to the Studio: upcoming patches milestone Oct 24, 2023
@KshitijThareja
Copy link
Contributor

Hi @vkWeb !
I would like to work on this issue. Can you please assign it to me?

@marcellamaki
Copy link
Member

Hi @KshitijThareja - thank you. I'll assign you. Let us know if you have any questions.

@KshitijThareja
Copy link
Contributor

Sure, and thanks @marcellamaki.

@KshitijThareja
Copy link
Contributor

@marcellamaki @vkWeb I have made the required changes. Can you please review the linked PR? Thanks : )

@marcellamaki
Copy link
Member

Thank you @KshitijThareja - I will assign the PR to some team members to review this week, and we will follow up with feedback if any.

@bjester
Copy link
Member Author

bjester commented Oct 31, 2023

Closed by #4319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome
Projects
None yet
Development

No branches or pull requests

6 participants