-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misalignment of copy failure retry CTA #4272
Comments
hi @MisRob mam , I am here |
Thanks, @yash1378. @vkWeb will provide you with a bit more info on where to find this place. See https://github.com/learningequality/studio#readme for how to setup Studio. |
@yash1378 Hi Yash, first, as already said by @MisRob, setup Studio and then try reproducing the copy error UI state as mentioned in the updated post above. Yash, once you have setup Studio and reproduced copy error UI state, try using chrome dev tools to see the CSS properties of the copying error message. Please let me know if you have any questions. Feel free to ask even the silliest of questions, every question is important. We appreciate your help Yash. Looking forward! |
thanx sir for helping , yes i will try hard |
@yash1378 what's up, how's all going? |
@yash1378 I'm unassigning this as it looks like you are away. Anyways, thanks for looking into this, appreciated! This issue is now open to take on for others. |
Hi @vkWeb ! |
Hi @KshitijThareja - thank you. I'll assign you. Let us know if you have any questions. |
Sure, and thanks @marcellamaki. |
@marcellamaki @vkWeb I have made the required changes. Can you please review the linked PR? Thanks : ) |
Thank you @KshitijThareja - I will assign the PR to some team members to review this week, and we will follow up with feedback if any. |
Closed by #4319 |
We recently pushed a feature that allows users to retry failed copy of contentnodes. There's an UI bug between the alignment of copying message and retry action message as shown in the below image --
Here are some pointers to get started --
To reproduce the copy error UI state in the frontend you will need to raise an exception from the backend copying function. The exception from the backend copying function can be raised by raising any ValidationError.
The copying message text is present in ContentNodeListItem.
The retry copy action text is present in ContentNodeEditListItem.
The text was updated successfully, but these errors were encountered: