-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caption support with new models, vuex, and edit modal integration #4151
base: gsoc/transcription
Are you sure you want to change the base?
Add caption support with new models, vuex, and edit modal integration #4151
Conversation
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.27.1 to 4.40.0. - [Release notes](https://github.com/fonttools/fonttools/releases) - [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst) - [Commits](fonttools/fonttools@4.27.1...4.40.0) --- updated-dependencies: - dependency-name: fonttools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [workbox-precaching](https://github.com/googlechrome/workbox) from 6.5.4 to 7.0.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v6.5.4...v7.0.0) --- updated-dependencies: - dependency-name: workbox-precaching dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
contentcuration/contentcuration/frontend/channelEdit/components/CaptionsTab/CaptionsTab.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/actions.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/getters.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/currentChannel/getters.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/vuex/caption/mutations.js
Outdated
Show resolved
Hide resolved
queryset = queryset.filter(file_id__in=file_ids) | ||
|
||
if file_id: | ||
queryset = queryset.filter(file_id=file_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to the above comment, could you also check File.filter_edit_queryset
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if file_id:
allowed_file_id = set(
File.filter_edit_queryset(
File.objects.get(pk=file_id), self.request.user
)
.values_list("id", flat=True)
)
queryset = queryset.filter(file_id=allowed_file_id)
Please check this.
I think there won't be comma seperated file_ids
. (we don't actually use this query for now)
Summary
Description of the change(s) you made
This PR adds caption files and cues models leveraging the change event architecture. It also:
Frontend
Captions
tab to the edit modal for managing and generating captions, visually controlled byfeature flags
vuex
to manage the state for captions. Which is integrated into theEditModal
andEditList
components.Backend
CaptionFile
andCaptionCue
models. The models leverage the change event architecture to track changes.Manual verification steps
TODO
References
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)