Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2024.06.04 #4518

Merged
merged 61 commits into from
Jun 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
6fe058f
Fix misalignment of copy failure retry
KshitijThareja Oct 30, 2023
e71e478
Change alignment of retry button
KshitijThareja Oct 31, 2023
b3b43ac
Merge pull request #4319 from KshitijThareja/4272
bjester Oct 31, 2023
052b5a9
[fix] Import applied language filter
FidalMathew Jan 3, 2024
d16b50b
add languageFilter event
FidalMathew Jan 6, 2024
30ca0af
fix naming
FidalMathew Jan 7, 2024
a506b79
fix languages bug
FidalMathew Jan 10, 2024
f5d6319
Minor logic refactor
vkWeb Jan 11, 2024
4dde334
Merge pull request #4376 from FidalMathew/my-hotfixes
vkWeb Jan 11, 2024
ce82a4c
Upgrade Studio to KDS 3.0.0 (2/3)
MisRob Jan 22, 2024
950565f
Upgrade Studio to KDS 3.0.0 (3/3)
MisRob Jan 22, 2024
4d0ac3b
Finalize upgrade to v3+ of KDS
bjester Feb 23, 2024
cccd0d8
Updates grey shade usages
akolson Feb 27, 2024
eeabbf6
AppBar color upgrade
akolson Feb 27, 2024
7b562e7
Cherry-picks theming base work
rtibbles Jan 16, 2024
ef04e91
updates yarn.lock
akolson Feb 28, 2024
2823d9d
implements further rebrand changes
akolson Feb 28, 2024
4b894b3
Removes console log
akolson Feb 29, 2024
6cf31f8
Merge pull request #4454 from bjester/hotfixes-kds
marcellamaki Mar 5, 2024
bd033b1
Updates studio to use KDS library
akolson Mar 5, 2024
fad5f46
changes immersive bar color to black
akolson Mar 18, 2024
51da497
Updates colors
akolson Mar 19, 2024
15c3511
Updates KLogo
akolson Mar 29, 2024
02484aa
Updates logo usages to guidelines
akolson Apr 12, 2024
0cb9338
Updates logo usages to guidelines
akolson Apr 12, 2024
5b686cf
Updates KDS version + warning icon color
akolson Apr 16, 2024
dc3a7cb
Updates warning icon color
akolson Apr 16, 2024
a3cf778
Fixes incorrect coach content icon color
akolson Apr 17, 2024
f0fa1f6
Merge pull request #4459 from akolson/studio_rebranding
bjester Apr 17, 2024
82e8578
Merge branch 'master' into hotfixes
akolson Apr 17, 2024
af3e726
Update welcome email
bjester Apr 18, 2024
7b37a86
Merge pull request #4520 from bjester/welcome-rebranded
bjester Apr 18, 2024
9f49868
Updates Create an account logo
akolson Apr 18, 2024
fe96294
Adds new LE logo
akolson Apr 18, 2024
340da6c
Merge pull request #4522 from akolson/updates-create-account-logo
bjester Apr 19, 2024
7ef7bf4
Properly format node_id+channel_id query parameter
bjester Apr 22, 2024
19a15f5
Fix linting issue
bjester Apr 22, 2024
ce5db02
Fix hover color for red delete account button
bjester Apr 22, 2024
6d74de8
Merge pull request #4531 from bjester/delete-account-rebrand
bjester Apr 23, 2024
d95e5a6
Merge pull request #4530 from bjester/import-search-clipboard
bjester Apr 23, 2024
09411c9
Updates logo dimensions
akolson Apr 23, 2024
6b03b04
Resolve issue writing LE logo to canvas
bjester Apr 24, 2024
2c021fe
Merge pull request #4523 from akolson/update-le-logo
marcellamaki Apr 24, 2024
73d591b
Update all kolibri logo images in Studio.
rtibbles Apr 26, 2024
75d4602
Fix widely repeated typo in logo file reference.
rtibbles Apr 26, 2024
fb5a3d1
Merge pull request #4539 from rtibbles/logo_jojo
bjester Apr 29, 2024
471032c
Update favicon to have no background.
rtibbles May 1, 2024
defee15
Merge pull request #4546 from rtibbles/new_favicon
bjester May 1, 2024
022d8f8
Update VCard usage and hover styling
bjester May 2, 2024
9fa3c8c
Update admin row hover color
bjester May 2, 2024
b10e54b
Add scss file handling to jest config
bjester May 2, 2024
87fb9d9
Merge pull request #4549 from bjester/hover-cards
bjester May 2, 2024
ea5fb6b
Add some things to nginx config
bjester May 15, 2024
6dffc0b
Merge pull request #4564 from bjester/nginx-tweaks
rtibbles May 16, 2024
219de70
Switch back to $proxy_host
bjester May 16, 2024
f42405c
Merge pull request #4568 from bjester/nginx-tweaks
bjester May 17, 2024
ef69a7f
add spacing and hover state to channel list cards
marcellamaki May 23, 2024
b10e013
Merge pull request #4574 from marcellamaki/hover-card-rebrand
bjester May 23, 2024
77ce2f7
Remove pinned covid channel collection
bjester May 30, 2024
7d91bad
Remove tests for public collections
bjester May 30, 2024
07dde98
Merge pull request #4581 from bjester/covid-free
marcellamaki Jun 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
:appBarText="$tr('backToLoginButton')"
backButton
>
<VImg
height="200"
maxHeight="100"
contain
:lazy-src="require('shared/images/kolibri-logo.svg')"
:src="require('shared/images/kolibri-logo.svg')"
/>
<div class="align-center d-flex justify-center mb-2">
<KLogo
altText="Kolibri Logo with background"
:showBackground="true"
:size="120"
/>
</div>
<h2 ref="top" class="mb-4 primary--text text-xs-center">
{{ $tr('createAnAccountTitle') }}
</h2>
Expand Down
19 changes: 12 additions & 7 deletions contentcuration/contentcuration/frontend/accounts/pages/Main.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@
class="pa-4"
style="width: 300px;margin: 0 auto;"
>
<VImg
height="200"
maxHeight="100"
contain
:lazy-src="require('shared/images/kolibri-logo.svg')"
:src="require('shared/images/kolibri-logo.svg')"
/>
<div class="k-logo-container">
<KLogo
altText="Kolibri Logo with background"
:showBackground="true"
:size="120"
/>
</div>
<h2 class="primary--text py-2 text-xs-center">
{{ $tr('kolibriStudio') }}
</h2>
Expand Down Expand Up @@ -227,4 +227,9 @@
width: 100%;
}

.k-logo-container {
display: flex;
justify-content: center;
}

</style>
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@

tr:hover td {
/* stylelint-disable-next-line custom-property-pattern */
background-color: var(--v-greyBackground-base) !important;
background-color: var(--v-greyBackground-lighten1) !important;
}

/deep/ .v-table__overflow {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<template #progress>
<VProgressLinear
v-if="loading"
color="primary"
color="loading"
indeterminate
data-test="loading"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
:class="{ expanded: $vuetify.breakpoint.mdAndUp }"
>
<template #progress>
<VProgressLinear v-if="loading" color="primary" indeterminate />
<VProgressLinear v-if="loading" color="loading" indeterminate />
</template>

<template #headerCell="{ header }">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@
}

.copy-retry-btn {
padding-bottom: 2px;
font-size: inherit;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@
align-items: center;
align-self: center;
min-width: max-content;
line-height: 1.6;
pointer-events: auto;
cursor: default;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<span v-else-if="error" class="mx-2">
<VTooltip bottom lazy>
<template #activator="{ on }">
<Icon color="red" v-on="on">
<Icon :color="$themePalette.red.v_1100" v-on="on">
error
</Icon>
</template>
Expand All @@ -19,7 +19,7 @@
<span v-else-if="warning" class="mx-2">
<VTooltip bottom lazy>
<template #activator="{ on }">
<Icon color="amber" v-on="on">
<Icon :color="$themePalette.yellow.v_1100" v-on="on">
warning
</Icon>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
v-if="loading"
class="mx-3"
indeterminate
color="loading"
size="15"
width="2"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<!-- Toolbar + extension -->
<VToolbar
dark
color="primary"
color="appBarDark"
fixed
flat
:clipped-left="!$isRTL"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<div class="mx-2">
<template v-if="hasChanges">
<VProgressCircular indeterminate size="16" width="2" color="secondary" />
<VProgressCircular indeterminate size="16" width="2" color="loading" />
<span class="mx-2" style="vertical-align: middle;">
{{ $tr('savingIndicator') }}
</span>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>

<VCard @click="handleClick">
<VCard hover @click="handleClick">
<VCardTitle>
<VLayout row wrap>
<VFlex class="pt-2 px-4 thumbnail-column">
Expand Down Expand Up @@ -229,11 +229,6 @@

.v-card {
cursor: pointer;

&:hover {
/* stylelint-disable-next-line custom-property-pattern */
background-color: var(--v-greyBackground-base);
}
}

h3 {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>

<VCard :to="channelRoute">
<VCard hover :to="channelRoute">
<VCardTitle>
<VLayout row wrap>
<VFlex lg2 md4 sm5 xs12 class="px-3">
Expand Down Expand Up @@ -113,11 +113,6 @@

.v-card {
cursor: pointer;

&:hover {
/* stylelint-disable-next-line custom-property-pattern */
background-color: var(--v-greyBackground-base);
}
}

</style>
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
mixins: [constantsTranslationMixin],
data() {
return {
languageFilter: '',
languageFilter: null,
channels: [],
pageCount: 0,
loading: false,
Expand Down Expand Up @@ -110,6 +110,7 @@
},
languageFilter() {
this.loadPage();
this.$emit('update-language', this.languageFilter);
},
},
mounted() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
<!-- Search or Topics Browsing -->
<ChannelList
v-if="isBrowsing && !$route.params.channelId"
@update-language="updateLanguageQuery"
/>
<ContentTreeList
v-else-if="isBrowsing"
Expand Down Expand Up @@ -96,6 +97,7 @@
searchTerm: '',
topicNode: null,
copyNode: null,
languageFromChannelList: null,
};
},
computed: {
Expand Down Expand Up @@ -142,6 +144,9 @@
handleBackToBrowse() {
this.$router.push(this.backToBrowseRoute);
},
updateLanguageQuery(language) {
this.languageFromChannelList = language;
},
handleSearchTerm() {
if (this.searchIsValid) {
this.$router.push({
Expand All @@ -151,9 +156,11 @@
},
query: {
...this.$route.query,
...(this.isBrowsing ? { languages: this.languageFromChannelList } : {}),
last: this.$route.query.last || this.$route.path,
},
});
this.languageFromChannelList = null;
this.clearNodes();
this.$analytics.trackAction('import_modal', 'Search');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
v-on="on"
>
{{ $formatNumber(errorsInChannel) }}
<Icon color="amber">
<Icon :color="$themePalette.yellow.v_1100">
warning
</Icon>
</div>
Expand Down Expand Up @@ -204,7 +204,7 @@
<slot name="extension"></slot>
</template>
</ToolBar>
<MainNavigationDrawer v-model="drawer" />
<MainNavigationDrawer v-model="drawer" color="white" />
<slot></slot>

<PublishModal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export function addClipboardNodeFromListener(context, obj) {
.then(() =>
context.dispatch(
'contentNode/loadContentNodes',
{ '[node_id+channel_id]__in': [obj.source_node_id, obj.source_channel_id] },
{ '[node_id+channel_id]__in': [[obj.source_node_id, obj.source_channel_id]] },
{ root }
)
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,68 +19,6 @@
@click="clearFilters"
/>
</div>
<div v-else>
<VLayout row wrap>
<VFlex
v-for="collection in collections"
:key="`public-collection-${collection.id}`"
xs12
class="py-2"
>
<VCard
tabindex="0"
class="pt-2"
data-test="collection"
@click="setCollection(collection.id)"
@keyup.enter="setCollection(collection.id)"
>
<VLayout>
<div class="px-2 text-xs-center">
<Icon style="font-size: 75px;">
local_hospital
</Icon>
</div>
<VCardTitle primary-title class="pb-2 pt-2">

<!-- TODO: add 'notranslate' class once we figure out how to handle collections
that have multiple channel languages inside -->
<h3 class="headline mb-0">
{{ collection.name }}
</h3>
<p class="body-1 grey--text">
{{ $tr('channelCount', { count: collection.count }) }}
</p>
<p v-if="collection.description">
{{ collection.description }}
</p>
</VCardTitle>
</VLayout>
<VCardActions>
<VSpacer />
<IconButton
icon="copy"
:text="$tr('copyToken')"
@click.stop="displayToken = collection.token"
/>
</VCardActions>
</VCard>
</VFlex>
</VLayout>

<KModal
v-if="displayToken"
:title="$tr('copyTitle')"
:text="$tr('copyTokenInstructions')"
:cancelText="$tr('close')"
@cancel="displayToken = null"
>
<div class="mb-3">
{{ $tr('copyTokenInstructions') }}
</div>
<CopyToken :token="displayToken" />
</KModal>

</div>
</VContainer>

</template>
Expand All @@ -90,10 +28,6 @@
import flatten from 'lodash/flatten'; // Tests fail with native Array.flat() method
import { catalogFilterMixin } from './mixins';
import { constantsTranslationMixin } from 'shared/mixins';
import IconButton from 'shared/views/IconButton';
import CopyToken from 'shared/views/CopyToken';

const publicCollections = window.publicCollections || [];

/*
Returns the expected format for filters
Expand All @@ -108,16 +42,7 @@

export default {
name: 'CatalogFilterBar',
components: {
IconButton,
CopyToken,
},
mixins: [constantsTranslationMixin, catalogFilterMixin],
data() {
return {
displayToken: null,
};
},
computed: {
currentFilters() {
return flatten([
Expand Down Expand Up @@ -150,24 +75,10 @@
createFilter(this.coach, this.$tr('coachContent'), this.resetCoach),
createFilter(this.assessments, this.$tr('assessments'), this.resetAssessments),
createFilter(this.subtitles, this.$tr('subtitles'), this.resetSubtitles),
createFilter(this.collection, this.getCollectionName(), this.resetCollection),
]).filter(Boolean);
},
collections() {
return publicCollections;
},
},
methods: {
getCollectionName() {
const collection = this.collections.find(c => c.id === this.collection);
return collection && collection.name;
},
setCollection(collectionId) {
this.collection = collectionId;
},
resetCollection() {
this.setCollection(null);
},
resetKeywords() {
this.keywords = '';
},
Expand Down Expand Up @@ -200,12 +111,6 @@
subtitles: 'Subtitles',
starred: 'Starred',
clearAll: 'Clear all',
channelCount: '{count, plural,\n =1 {# channel}\n other {# channels}}',
copyToken: 'Copy collection token',
copyTitle: 'Copy collection token',
copyTokenInstructions:
'Paste this token into Kolibri to import the channels contained in this collection',
close: 'Close',
},
};

Expand Down
Loading