-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement recommendations display #4803
base: search-recommendations
Are you sure you want to change the base?
Implement recommendations display #4803
Conversation
…endations-display
…endations-display
…endations-display
Thanks @akolson! I will prioritize reviewing parts related to cards in this PR and follow-up on your Slack feedback on that opportunity. |
…mplement-recommendations-display # Conflicts: # contentcuration/contentcuration/frontend/RecommendedResourceCard/components/RecommendedResourceCard.vue # package.json # yarn.lock
@akolson Chiming in to say so far so good! The way the card is implemented around |
Summary
Description of the change(s) you made
This pr Implements the following
" page. See reference for details.
Manual verification steps performed
Screenshots (if applicable)
Good recommendations
Pagination - View more good recommendation
Pagination - Other (not so good) recommendations
Pagination - No good recommendations
Loading state
About recommendations
AI feature flag off
Are there any risky areas that deserve extra testing?
References
Closes #4565
Closes #4566
Closes #4683
Closes #4775
Comments
The
KCard
component is generally in a good place, however there could be few issues that could pop up here and there. For the latest changes you canyarn link
the KDSdevelop
branch or use the latest release on npm, if up-to-date withdevelop
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)