Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release v2024.12.03 #4830

Merged
merged 40 commits into from
Dec 4, 2024
Merged

Patch release v2024.12.03 #4830

merged 40 commits into from
Dec 4, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Nov 18, 2024 •
edited
Loading

Summary

  • Adds missing pagination to trash and move modal
  • Addresses query performance issues when opening channels and their details, and when processing garbage collection
  • Adds untranslated string for IMSCP option which became visible in content edit modal
  • Fixes issues editing user storage within internal admin interface
  • Addresses issues cheffing a previously deleted channel
  • Fixes issue where modal appeared persistently when rearranging resources in a folder that has metadata
  • Fixes pagination issue in channel trash where loading more prepended trashed items to the view
  • Prepares for PostgreSQL 12

Pull Requests

PR Issues Category QA Focus
#4785 #4783 Bug Chef a previously deleted channel
#4791 #4790 Bug Edit user's storage space in admin
#4807 #4793 Bug Open channel details for new / empty channel
#4808 #4780 Bug N/A - already tested
#4810 #4809 Bug Ensure all trashed items are visible,
and all target folder contents are visible when moving
#4818 #4789 Bug Upload HTML5 and verify IMSCP option
#4824 #4795 Bug Open channel details for large channel like Khan Academy
#4826 #4825 Bug Open Sikana channel
#4845 #4837 Bug Loading more items in trash appends to view
#4849 #4839 Bug Inherit modal doesn't appear when sorting
a folder's resources, when it has metadata
#4794 #4788 Task N/A
#4821 / #4778 #4777 Task N/A
#4834 N/A Task Studio is functional
#4835 N/A Task Studio is functional
#4847 N/A Task N/A - already tested by @nucleogenesis

rtibbles and others added 29 commits October 9, 2024 12:55
@rtibbles
Add regression test for case where internal create channel method tri…
bcc2873 
…ggers undeletion.

Fix error.
@rtibbles
Merge pull request #4785 from rtibbles/acting_up
0232932 
Ensure actor_id gets passed in case channel creation API endpoint ends up in undeleting channel
@rtibbles
Revert accidental change to update as admin method.
5d25fac
@ozer550
tests and validation for invalid uuid
6726e56
@rtibbles
Merge pull request #4794 from ozer550/add-validation-for-pk-public-api
624963b 
Validate UUID Format in Public API Requests to Prevent 500 Errors
@rtibbles
Add two defensive programming checks to stop 500s when getting channe…
710927f 
…l details.
@rtibbles
Require the root node to have descendant resources, not just descenda…
e18df39 
…nt nodes

in order to publish.
@ozer550
optimize garabge collection command
86062a3
@ozer550
fix model in the query
d2e9353
@rtibbles
Add pagination to trash modal.
4f962db
@rtibbles
Add pagination to move modal.
7c31713
@rtibbles
Add pagination to import modal.
41615c1
@ozer550
indiviually loop through contentnodes for updates
b849dbc
@bjester
Merge pull request #4807 from rtibbles/channel_details_modal
3ef9044 
Channel details modal fixes
@ozer550
avoid iterating over every channel
7038023
@akolson
Adds missing string(IMSCP) for HTML5 file type
5a26027
@bjester
Merge pull request #4818 from akolson/adds-missing-imscp-string
d8f95b5 
Adds missing string(IMSCP) for HTML5 file type
@bjester
Merge pull request #4808 from ozer550/optimize-garbage-collection-com…
eb3aadc 
…mand

optimize garabge collection command
@ozer550 @bjester
clean up migrations
0ab30af
@bjester
Merge pull request #4821 from bjester/pick-migration-removal
c874a46 
cherry-pick #4778: clean up migrations
@bjester
Merge pull request #4791 from rtibbles/going_into_administration
faa4274 
Revert accidental change to update as admin method.
@rtibbles
Update loadChildren mock in trash model tests.
928d5b8
@rtibbles
Merge pull request #4810 from rtibbles/paging_dr_idiot
78b3b71 
Add pagination to every place that displays long lists of nodes from loadChildren
@bjester
Update node details query to use CTE, and more robust tests
3288945
@bjester
Add analytics for viewing details
2ee61dc
@bjester
Remove bucket persistence in tests
dad41bb
@bjester
Use CTE for server rev query, add tests
6cc44b4
@rtibbles
Merge pull request #4824 from bjester/far-fetching-sql-details
e349e81 
Update node details query to use CTE and more robust tests
@rtibbles
Merge pull request #4826 from bjester/load-channel-rev
f1caf61 
Use CTE for server rev query, add tests
bjester and others added 5 commits November 19, 2024 08:37
This was referenced Nov 22, 2024
Closed
Closed
@pcenov
Copy link
Member

pcenov commented Nov 25, 2024

Hi @bjester and @radinamatic I've finished verifying the above listed fixes plus running the CWs and the only issues found are linked to this PR.

@bjester bjester changed the title Patch release v2024.12.01 Patch release v2024.12.03 Dec 4, 2024
@pcenov pcenov mentioned this pull request Dec 4, 2024
Open
radinamatic
radinamatic approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, non-blocking follow-up issues filed, good to go! 👍🏽 🚀 :shipit:

@akolson akolson self-requested a review December 4, 2024 16:50
akolson
akolson approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@bjester bjester merged commit d55da21 into master Dec 4, 2024
34 checks passed
@bjester bjester mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

@akolson akolson akolson approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees

@radinamatic radinamatic

@marcellamaki marcellamaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bjester @pcenov @radinamatic @akolson @marcellamaki @rtibbles @ozer550