Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates kds breaking changes #4842

Merged

Conversation

akolson
Copy link
Member

@akolson akolson commented Nov 27, 2024

Summary

This pr update studio to use the latest KDS v 5.0.0_rc10, and also fixes any breaking changes introduced by the same. The guide below is used;
Theme Token Changes

References

Fixes #4816

Reviewer guidance

  • Browse through the UI to ensure that the colors remain as before. The studio production version can be used as a guide.
  • While reviewing the code changes, ensure the mapping has been applied based on the guideline shared above( and in the reference too).

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akolson! This LGTM! I havent spotted any missing update to handle the breaking changes. And everything looks fine on manual QA. I just found a little choppy animation when we open a KModal, but this is something I have reported separately in KDS learningequality/kolibri-design-system#848. Thanks!

@akolson akolson merged commit d687a5c into learningequality:unstable Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump KDS from 4.5.1 to 5.0.0-rc10
2 participants