Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check to the "Imported from" link to verify source nodes exist before attempting a navigation #4846

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

akolson
Copy link
Member

@akolson akolson commented Dec 3, 2024

Summary

This pr improves the user experience when a user clicks the "Imported from" link whose source content no longer exists (or has been deleted). A check is performed to ascertain that the source node still exists before attempting to perform navigation.

Screen.Recording.2024-11-28.at.21.20.37.mov

i18n
Please note that this pr introduces a new string that will require translation before deployment to production. Adding @radinamatic as reviewer to keep track.

References

Fixes #4828

Reviewer guidance

DO NOT do this in Production

  1. Import content from another channel
  2. Delete the source content node
  3. Click the 'Import from' link on the copy

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this. Unfortunately, this doesn't quite achieve the desired result yet. I believe it's because the link still has the href, and so the click handler does not prevent the navigation.

@akolson
Copy link
Member Author

akolson commented Dec 12, 2024

Hi @bjester! 👀 Completely skipped cleaning up the href references (I guess during the retargeting). We should be good now. Thanks for pointing this out.

@akolson akolson requested a review from bjester December 12, 2024 09:06
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works! Thanks @akolson

@bjester bjester merged commit a81876e into learningequality:unstable Dec 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to load source node from imported copy produces blank screen
2 participants