Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made background color on hover of the caption area more subtle #4860

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

shruti862
Copy link
Contributor

Summary

Made background colour on hover of the caption area more subtle.
After Changes Screenshot:
Screenshot from 2024-12-17 19-55-46

References

Addresses issue #4836

Reviewer guidance

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shruti862,

Thank you for your contribution. Studio has been slowly replacing Vuetify theming with our own ecosystem design library. I left code comments providing context on this. I'm requesting a slightly more involved change (with respect to changing a color 😄), but there are helpful examples in the linked documentation.

@shruti862
Copy link
Contributor Author

@bjester Thank you for reviewing my PR ; I have done the suggested changes in new commit ,please have a look .

@bjester bjester self-requested a review December 18, 2024 15:27
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shruti862 !

@bjester bjester merged commit 92ecf29 into learningequality:unstable Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants