Skip to content

Commit

Permalink
chore: remove win code signing
Browse files Browse the repository at this point in the history
  • Loading branch information
kyranjamie committed Oct 24, 2023
1 parent 754e4d6 commit 68fde1d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/debug-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ jobs:
- os: windows-latest
NPM_COMMAND: win
UPLOAD_ASSETS: release/**/*.exe
CSC_LINK_SECRET_NAME: CODE_SIGNING_CERTIFICATE_WINDOWS
CSC_KEY_PASSWORD_SECRET_NAME: CODE_SIGNING_PASSWORD_WINDOWS

steps:
- name: Cancel Previous Runs
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/publish-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ jobs:
- os: windows-latest
NPM_COMMAND: win
UPLOAD_ASSETS: release/**/*.exe
CSC_LINK_SECRET_NAME: CODE_SIGNING_CERTIFICATE_WINDOWS
CSC_KEY_PASSWORD_SECRET_NAME: CODE_SIGNING_PASSWORD_WINDOWS

steps:
- name: Cancel Previous Runs
Expand Down Expand Up @@ -87,6 +85,7 @@ jobs:
if: matrix.os == 'windows-latest'

- name: Build releases
if: matrix.os == 'macos-11'
run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -98,6 +97,15 @@ jobs:
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASS }}

- name: Build releases
if: matrix.os != 'macos-11'
run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NODE_ENV: production
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY }}

- uses: actions/upload-artifact@v2
name: ${{ matrix.os }} upload
with:
Expand Down

0 comments on commit 68fde1d

Please sign in to comment.