Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't treat dataclasses with decoding fns as dataclasses, fixes #266 #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlwh
Copy link

@dlwh dlwh commented Jun 21, 2023

No description provided.

Copy link
Owner

@lebrice lebrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I dont quite understand the issue atm. I'll give a proper review once I do.

For now though, the walrus operator is too recent to be included, sadly.

field_dataclass = utils.get_dataclass_type_arg(field_type)
# See if it's a generic with a dataclass arg
# if so, extract the dataclass type from the annotation of the field.
elif (field_dataclass := utils.get_dataclass_type_arg(field_type)) is not None and\
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use the walrus operator unfortunately, we want python 3.7+ support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants