Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(body-reader): do not call sock:receive for reading 0 bytes #313

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tieske
Copy link
Contributor

@Tieske Tieske commented Mar 18, 2024

Some sockets can block if called to read 0 bytes until actual bytes are available to read.

Some sockets can block if called to read 0 bytes until actual
bytes are available to read.
@Tieske
Copy link
Contributor Author

Tieske commented Mar 18, 2024

note that in the same code, slightly further down; we only read if length > 0

@Tieske
Copy link
Contributor Author

Tieske commented May 8, 2024

@pintsized any chance to get this merged?

lib/resty/http.lua Outdated Show resolved Hide resolved
lib/resty/http.lua Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants