Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support YAML files #49

Merged
merged 8 commits into from
Dec 30, 2023
Merged

Support YAML files #49

merged 8 commits into from
Dec 30, 2023

Conversation

gipert
Copy link
Member

@gipert gipert commented Dec 29, 2023

  • A database can be now composed either by JSON or YAML files (or a mix)
  • Refactored the code such that it will be easy to support additional file types in the future
  • JsonDB has been renamed to TextDB. JsonDB still usable but a deprecation warning will be emitted

@gipert gipert added the enhancement New feature or request label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (3ad061a) 72.60% compared to head (82e1d02) 73.22%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/legendmeta/police.py 11.76% 15 Missing ⚠️
src/legendmeta/textdb.py 81.25% 9 Missing ⚠️
src/legendmeta/catalog.py 75.00% 2 Missing ⚠️
src/legendmeta/utils.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   72.60%   73.22%   +0.61%     
==========================================
  Files           7        8       +1     
  Lines         741      773      +32     
==========================================
+ Hits          538      566      +28     
- Misses        203      207       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert marked this pull request as draft December 29, 2023 17:48
@gipert gipert marked this pull request as ready for review December 30, 2023 15:12
@gipert gipert merged commit a0de1dc into main Dec 30, 2023
11 checks passed
@gipert gipert deleted the dev branch December 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant