-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIP-6]: Profile Guardian Tied to ERC 6551 Wallet #23
base: main
Are you sure you want to change the base?
Conversation
|
|
||
## Specification | ||
|
||
The proposed modification involves linking the Profile Guardian to an ERC 6551 wallet. This association will allow users to manage the guardian on a per-profile basis, providing more granular control over their security settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please expand (even in reply to this comment for now) some practical examples of how this might look like?
Just by reading this I would assume you are hinting at a bespoke ERC 6551 that is somewhat Lens Profile aware.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what i understand the Lens profile now is a ERC 6551 and can be used as a wallet store followers store NFTS etc same way as ORB stores their community nfts inside i was thinking of linking the guardian to that entity rather to the wallet holding the profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were considering having ProfileGuardian as a whole modular system, that will allow different levels of protection:
- Protecting Wallet as a whole (as it is now)
- Protecting Collection as a whole
- Protecting Individual NFT in a Collection
With the latter overriding the former.
I think this LIP might be a special particular case of this system above. I think we don't need to particularly focus on 6551, as focusing on protecting an individual tokenID is basically the same thing, even if it is not 6551 (please correct me if I'm wrong)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 6551 was just an example of how it can be taken care of basically i mean that it would be to unprotect on of the acounts not all of them
I support this proposal but I think maybe the title should be re-worded from "tied to ERC 6551 wallet" to "tied to profile tokenID". Based on the comments I think the intended scope is for an address that owns multiple profiles to enable or disable profile guardian for individual profiles instead of all at once. This could be done by allowing This is particularly useful for ERC-6551 where an NFT can hold multiple profiles, but it would also work for any address that owns multiple profiles. Is this understanding correct @DanIsNearby and is this technically possible @vicnaum @donosonaumczuk ? |
No description provided.