feat: add advanced contract condition for gated-content #555
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Are all these changes intentional?
The peer dependencies are meant to be satisfied by the @lens-protocol/client (and later by the @lens-protocol/react) packages as this package is not a standalone public package.
| value: ':userAddress', | ||
| ...overrides, | ||
| }; | ||
| } |
There was a problem hiding this comment.
I see this helper but not use of it, was a test suite meant to be checked-in?
There was a problem hiding this comment.
yeah tests are still WIP, will push them soon
packages/gated-content/src/conditions/advanced-contract-condition.ts
Outdated
Show resolved
Hide resolved
packages/gated-content/src/conditions/advanced-contract-condition.ts
Outdated
Show resolved
Hide resolved
packages/gated-content/src/conditions/advanced-contract-condition.ts
Outdated
Show resolved
Hide resolved
| ); | ||
|
|
||
| // for bool, array, tuple results we only allow equal/not equal | ||
| if (['bool', 'array', 'tuple'].includes(fn.outputs[0].baseType)) { |
There was a problem hiding this comment.
I think this should be codified in the type and validation within the @lens-protocol/metadata package.
| contract: toRawNetworkAddress(gqlCondition.contract), | ||
| abi: gqlCondition.abi, | ||
| functionName: gqlCondition.functionName, | ||
| params: gqlCondition.params as string[], |
There was a problem hiding this comment.
is this because of a readonly?
There was a problem hiding this comment.
yeah, open to suggestions to clean this up
cesarenaldi
force-pushed
the
T-14357/token-gated-pub-v3
branch
2 times, most recently
from
d1e3dde to
24d2c0e
Compare
zannis
force-pushed
the
T-14262/support-full-spectrum-of-lit-protocol-access-control
branch
from
ad4cc0a to
a9b46b5
Compare
| @@ -194,6 +196,19 @@ function toRawSimpleCondition(gqlCondition: gql.ThirdTierCondition): raw.SimpleC | |||
| follow: raw.toProfileId(gqlCondition.follow), | |||
| }); | |||
|
|
|||
| case 'AdvancedContractCondition': | |||
| return { | |||
There was a problem hiding this comment.
use the new raw.advancedContractCondition builder, it should reduce the boilerplate code here. Don't know if it can solve the readonly. Minor thing anyway.
| @@ -45,6 +45,9 @@ | |||
| }, | |||
| "license": "MIT", | |||
| "dependencies": { | |||
| "@ethersproject/abi": "^5.7.0", | |||
| "@ethersproject/address": "^5.7.0", | |||
| "@ethersproject/bignumber": "^5.7.0", | |||
There was a problem hiding this comment.
Unless something is changed these should stay as peer dependency only. Maybe there is an issue somewhere else, can you please clarify what made you make this change?
|
Merged here: #707 |
cesarenaldi
deleted the
T-14262/support-full-spectrum-of-lit-protocol-access-control
branch
No description provided.