Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react: add missing tests, remove unnecessary arg destructuring, remove limit overwrites #556

Merged
merged 2 commits into from
Oct 9, 2023
Merged

react: add missing tests, remove unnecessary arg destructuring, remove limit overwrites #556

merged 2 commits into from
Oct 9, 2023

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Oct 3, 2023

No description provided.

@height
Copy link

height bot commented Oct 3, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7877889

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lens-sdk-example-web-wagmi ❌ Failed (Inspect) Oct 9, 2023 8:36am

cesarenaldi
cesarenaldi reviewed Oct 4, 2023
View reviewed changes
packages/react/src/profile/__tests__/useProfile.spec.ts Outdated

return renderHookWithMocks(() => useProfile(args), {
mocks: {
sources,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove sources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm removing sources in another PR I'm working on right now, with useProfiles

@krzysu krzysu force-pushed the v2/add-tests branch 2 times, most recently from 250e3a6 to 1519bf3 Compare October 4, 2023 11:11
@krzysu krzysu marked this pull request as ready for review October 9, 2023 08:15
@krzysu krzysu changed the title react: add tests for useProfile and usePublication react: add missing tests, remove unnecessary arg destructuring, remove limit overwrites Oct 9, 2023
@krzysu krzysu merged commit d2d9966 into lens-v2 Oct 9, 2023
@krzysu krzysu deleted the v2/add-tests branch October 9, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysu @cesarenaldi