Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to support lens v2 #33

Merged
merged 1 commit into from
Nov 10, 2023
Merged

feat: upgrade to support lens v2 #33

merged 1 commit into from
Nov 10, 2023

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Nov 1, 2023 •
edited
Loading

includes:

  • update some deps
  • upgrade to LensClient v2
  • support v1 and v2 handle formats (v2 is namespace/handle)
  • update tests

TODO:

  • how the new handle format should look like in the URL? shall we change the manifest to specify :namespace and :localName separately? what about @ sign?

@height Height
Copy link

height bot commented Nov 1, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lens-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 10:27am

@krzysu krzysu force-pushed the lens-v2 branch 2 times, most recently from 384d58e to 17da570 Compare November 2, 2023 13:27
@krzysu krzysu marked this pull request as ready for review November 7, 2023 10:22
@cesarenaldi cesarenaldi merged commit 080767a into develop Nov 10, 2023
4 checks passed
@cesarenaldi cesarenaldi deleted the lens-v2 branch November 10, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarenaldi cesarenaldi cesarenaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysu @cesarenaldi