-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Sink MVP #1013
Merged
Merged
HTTP Sink MVP #1013
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b718a0
HTTP Sink WTD
davidsloan 04105fe
Unit tests
davidsloan 95fb6cc
Resource allocation
davidsloan cadf56e
* Implement SSL support
davidsloan c15ca41
Addressing some of the code review comments.
davidsloan 4850fa3
PR: Improved resource safety.
cmcmteixeira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
import Dependencies.globalExcludeDeps | ||
import Dependencies.gson | ||
|
||
import Settings._ | ||
import Settings.* | ||
import sbt.Keys.libraryDependencies | ||
import sbt._ | ||
import sbt.* | ||
import sbt.Project.projectToLocalProject | ||
|
||
import java.io.File | ||
|
@@ -22,6 +21,7 @@ lazy val subProjects: Seq[Project] = Seq( | |
elastic7, | ||
ftp, | ||
`gcp-storage`, | ||
http, | ||
influxdb, | ||
jms, | ||
mongodb, | ||
|
@@ -246,6 +246,28 @@ lazy val elastic7 = (project in file("kafka-connect-elastic7")) | |
.configureFunctionalTests() | ||
.enablePlugins(PackPlugin) | ||
|
||
lazy val http = (project in file("kafka-connect-http")) | ||
.dependsOn(common) | ||
//.dependsOn(`test-common` % "fun->compile") | ||
.settings( | ||
settings ++ | ||
Seq( | ||
name := "kafka-connect-http", | ||
description := "Kafka Connect compatible connectors to move data between Kafka and http", | ||
libraryDependencies ++= baseDeps ++ kafkaConnectHttpDeps, | ||
publish / skip := true, | ||
packExcludeJars := Seq( | ||
"scala-.*\\.jar", | ||
"zookeeper-.*\\.jar", | ||
), | ||
), | ||
) | ||
.configureAssembly(false) | ||
.configureTests(baseTestDeps ++ kafkaConnectHttpTestDeps) | ||
.configureIntegrationTests(baseTestDeps ++ kafkaConnectHttpTestDeps) | ||
//.configureFunctionalTests(kafkaConnectS3FuncTestDeps) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess the functional tests are to be added later? Do we need that line then? |
||
.enablePlugins(PackPlugin, ProtocPlugin) | ||
|
||
lazy val influxdb = (project in file("kafka-connect-influxdb")) | ||
.dependsOn(common) | ||
.settings( | ||
|
27 changes: 27 additions & 0 deletions
27
...in/scala/io/lenses/streamreactor/connect/cloud/common/sink/commit/CloudCommitPolicy.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright 2017-2024 Lenses.io Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.lenses.streamreactor.connect.cloud.common.sink.commit | ||
|
||
import com.typesafe.scalalogging.LazyLogging | ||
import io.lenses.streamreactor.connect.cloud.common.sink.config.FlushSettings.defaultFlushCount | ||
import io.lenses.streamreactor.connect.cloud.common.sink.config.FlushSettings.defaultFlushInterval | ||
import io.lenses.streamreactor.connect.cloud.common.sink.config.FlushSettings.defaultFlushSize | ||
|
||
object CloudCommitPolicy extends LazyLogging { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's no need to extend LazyLogging here right ? |
||
val Default: CommitPolicy = | ||
CommitPolicy(FileSize(defaultFlushSize), Interval(defaultFlushInterval), Count(defaultFlushCount)) | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
70 changes: 70 additions & 0 deletions
70
.../io/lenses/streamreactor/connect/cloud/common/sink/extractors/KafkaConnectExtractor.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 2017-2024 Lenses.io Ltd | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package io.lenses.streamreactor.connect.cloud.common.sink.extractors | ||
|
||
import cats.implicits.catsSyntaxEitherId | ||
import com.typesafe.scalalogging.LazyLogging | ||
import io.lenses.streamreactor.connect.cloud.common.sink.config.PartitionNamePath | ||
import org.apache.kafka.connect.data.Schema | ||
import org.apache.kafka.connect.data.Struct | ||
import org.apache.kafka.connect.errors.ConnectException | ||
import org.apache.kafka.connect.sink.SinkRecord | ||
|
||
import java.util | ||
import java.lang | ||
import java.nio.ByteBuffer | ||
import scala.jdk.CollectionConverters.MapHasAsJava | ||
|
||
object KafkaConnectExtractor extends LazyLogging { | ||
|
||
def extractFromKey(sinkRecord: SinkRecord, path: Option[String]): Either[Throwable, AnyRef] = | ||
extract(sinkRecord.key(), Option(sinkRecord.keySchema()), path) | ||
|
||
def extractFromValue(sinkRecord: SinkRecord, path: Option[String]): Either[Throwable, AnyRef] = | ||
extract(sinkRecord.value(), Option(sinkRecord.valueSchema()), path) | ||
|
||
// TODO: test with all different types | ||
private def extract( | ||
extractFrom: AnyRef, | ||
extractSchema: Option[Schema], | ||
maybePath: Option[String], | ||
): Either[Throwable, AnyRef] = { | ||
|
||
val maybePnp: Option[PartitionNamePath] = maybePath.map(path => PartitionNamePath(path.split('.').toIndexedSeq: _*)) | ||
(extractFrom, maybePnp) match { | ||
case (shortVal: lang.Short, _) => shortVal.asRight | ||
case (boolVal: lang.Boolean, _) => boolVal.asRight | ||
case (stringVal: lang.String, _) => stringVal.asRight | ||
case (longVal: lang.Long, _) => longVal.asRight | ||
case (intVal: lang.Integer, _) => intVal.asRight | ||
case (byteVal: lang.Byte, _) => byteVal.asRight | ||
case (doubleVal: lang.Double, _) => doubleVal.asRight | ||
case (floatVal: lang.Float, _) => floatVal.asRight | ||
case (bytesVal: Array[Byte], _) => bytesVal.asRight | ||
case (bytesVal: ByteBuffer, _) => bytesVal.array().asRight | ||
case (arrayVal: Array[_], _) => arrayVal.asRight | ||
case (decimal: BigDecimal, _) => decimal.asRight | ||
case (decimal: java.math.BigDecimal, _) => decimal.asRight | ||
case null => null | ||
case (structVal: Struct, Some(pnp)) => StructExtractor.extractPathFromStruct(structVal, pnp) | ||
case (mapVal: Map[_, _], Some(pnp)) => MapExtractor.extractPathFromMap(mapVal.asJava, pnp, extractSchema.orNull) | ||
case (mapVal: util.Map[_, _], Some(pnp)) => MapExtractor.extractPathFromMap(mapVal, pnp, extractSchema.orNull) | ||
case (listVal: util.List[_], Some(pnp)) => ArrayExtractor.extractPathFromArray(listVal, pnp, extractSchema.orNull) | ||
case otherVal => new ConnectException("Unknown value type: " + otherVal.getClass.getName).asLeft | ||
} | ||
} | ||
|
||
} |
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the functional tests are to be added later? Do we need that line then?