java connectors GitHub workflows #1145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsloan
reviewed
Apr 15, 2024
.github/workflows/java-build.yml
Outdated
| - name: Set up JDK 21 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 21 |
There was a problem hiding this comment.
https://docs.confluent.io/platform/current/installation/versions-interoperability.html
We can't build the release with jdk 21, 17 is the maximum for wide support unfortunately.
There was a problem hiding this comment.
Changed, thank you!
(I was originally thinking setting bytecode to 17 in Gradle will be enough, but let's stay on the safe side)
GoMati-MU
force-pushed
the
chore/java-connectors-github-workflows
branch
from
d265a4e to
cf2135b
Compare
|
moved to #1147 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Those changes to
Gradlebuild and new scripts to GitHub Actions should allowsbtandGradlebuilds to work simultaneously in order to allow for both java and scala connectors to be released alongside. This should also provide the base for further modules to be build by java and used by Scala.Testing
Below testing was done: