Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Commons Extraction- #1188

Merged
merged 2 commits into from
May 2, 2024
Merged

GCP Commons Extraction- #1188

merged 2 commits into from
May 2, 2024

Conversation

davidsloan
Copy link
Collaborator

  • Extracting new java module (gcp-commons) for use in both the GCP Storage connectors, and future planned connectors.
  • Rewriting GCP authentication code in Java.
  • Including unit testing.
  • Currently just in SBT - no gradle config created yet.

@gitguardian GitGuardian

This comment was marked as resolved.

Sign in to view
GoMati-MU
GoMati-MU suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@GoMati-MU GoMati-MU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good piece of code, but I left couple of remarks which should make pieces fit better logically

...fka-connect-common/src/main/java/io/lenses/streamreactor/common/config/base/RetryConfig.java Show resolved Hide resolved
...fka-connect-common/src/main/java/io/lenses/streamreactor/common/config/base/RetryConfig.java Outdated Show resolved Hide resolved
...t-common/src/main/java/io/lenses/streamreactor/common/config/base/intf/ConnectionConfig.java Show resolved Hide resolved
...a-connect-common/src/test/java/io/lenses/streamreactor/common/config/base/ConfigMapTest.java Outdated Show resolved Hide resolved
...-common/src/main/java/io/lenses/streamreactor/connect/gcp/common/auth/mode/AuthModeEnum.java Outdated Show resolved Hide resolved
...ommon/src/main/java/io/lenses/streamreactor/connect/gcp/common/auth/GCPConnectionConfig.java Outdated Show resolved Hide resolved
...st/java/io/lenses/streamreactor/connect/gcp/common/auth/GCPServiceBuilderConfigurerTest.java Outdated Show resolved Hide resolved
...st/java/io/lenses/streamreactor/connect/gcp/common/auth/GCPServiceBuilderConfigurerTest.java Show resolved Hide resolved
...-common/src/test/java/io/lenses/streamreactor/connect/gcp/common/auth/mode/TestFileUtil.java Show resolved Hide resolved
...-common/src/test/java/io/lenses/streamreactor/connect/gcp/common/auth/mode/TestFileUtil.java Show resolved Hide resolved
@davidsloan davidsloan force-pushed the chore/gcp-commons-extraction-java branch 2 times, most recently from 2607bc5 to 743d756 Compare May 1, 2024 16:42
davidsloan added 2 commits May 1, 2024 17:46
@davidsloan
GCP Commons Extraction-
c03b402 
* Extracting new java module (gcp-commons) for use in both the GCP Storage connectors, and future planned connectors.
* Rewriting GCP authentication code in Java.
* Including unit testing.
* Currently just in SBT - no gradle config created yet.
@davidsloan
Tweaks prompted by review comments
a701691
@davidsloan davidsloan force-pushed the chore/gcp-commons-extraction-java branch from 743d756 to a701691 Compare May 1, 2024 16:47
@davidsloan davidsloan enabled auto-merge (squash) May 2, 2024 10:30
@stheppi stheppi disabled auto-merge May 2, 2024 10:33
@stheppi stheppi merged commit 26d8f26 into master May 2, 2024
158 checks passed
@stheppi stheppi deleted the chore/gcp-commons-extraction-java branch May 2, 2024 10:33
@davidsloan davidsloan mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoMati-MU GoMati-MU GoMati-MU requested changes

@stheppi stheppi stheppi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidsloan @stheppi @GoMati-MU